Bug 189565 – Add support for HEVC codec types in Media Capabilities

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Add support for HEVC codec types in Media Capabilities

[Jer Noble]

Created attachment 349595 [details]
Patch

[Jer Noble]

Created attachment 349596 [details]
Patch

[Sam Weinig]

Comment on attachment 349596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349596&action=review

> Source/WTF/ChangeLog:11
> +        * wtf/text/StringConversion.h: Added.

We already have a wtf/text/IntegerToStringConversion.h, so might I suggest naming this wtf/text/StringToIntegerConversion.h?

> Source/WTF/wtf/text/StringConversion.h:28
> +inline bool isCharacterAllowedInBase(UChar c, int base)

You probably want this (and the rest of the file) in the WTF namespace.

[Sam Weinig]

Comment on attachment 349596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349596&action=review

> Source/WTF/ChangeLog:3
> +        Add support for HEVC codec types in Media Capabilities

This patch does not seem to have anything to do with this.

[EWS Watchlist]

Comment on attachment 349596 [details]
Patch

Attachment 349596 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9197494

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html

[EWS Watchlist]

Created attachment 349610 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 349596 [details]
Patch

Attachment 349596 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9198433

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html

[EWS Watchlist]

Created attachment 349616 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Jer Noble]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 349596 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349596&action=review
> 
> > Source/WTF/ChangeLog:11
> > +        * wtf/text/StringConversion.h: Added.
> 
> We already have a wtf/text/IntegerToStringConversion.h, so might I suggest
> naming this wtf/text/StringToIntegerConversion.h?

Good idea.

> > Source/WTF/wtf/text/StringConversion.h:28
> > +inline bool isCharacterAllowedInBase(UChar c, int base)
> 
> You probably want this (and the rest of the file) in the WTF namespace.

Will do.

(In reply to Sam Weinig from comment #4)
> Comment on attachment 349596 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349596&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        Add support for HEVC codec types in Media Capabilities
> 
> This patch does not seem to have anything to do with this.

Whoops, webkit-patch upload'd from the Source/WTF directory and missed the bulk of this patch. Will retry.

[Jer Noble]

Created attachment 349908 [details]
Patch

[Jer Noble]

Created attachment 349910 [details]
Patch

[Jer Noble]

Created attachment 349912 [details]
Patch

[Eric Carlson]

Comment on attachment 349912 [details]
Patch

r=me once the bots are happy with the patch

[Jer Noble]

Created attachment 349921 [details]
Patch for landing

[Radar WebKit Bug Importer]

<rdar://problem/44531065>

[Jer Noble]

Created attachment 349922 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 349922 [details]
Patch for landing

Clearing flags on attachment: 349922

Committed r236094: <https://trac.webkit.org/changeset/236094>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.