Bug 189565 - Add support for HEVC codec types in Media Capabilities
Summary: Add support for HEVC codec types in Media Capabilities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-12 15:34 PDT by Jer Noble
Modified: 2018-09-17 16:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (52.11 KB, patch)
2018-09-12 16:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (8.52 KB, patch)
2018-09-12 16:36 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.82 MB, application/zip)
2018-09-12 18:43 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.74 MB, application/zip)
2018-09-12 20:10 PDT, EWS Watchlist 		no flags Details
Patch (57.16 KB, patch)
2018-09-17 11:11 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (60.70 KB, patch)
2018-09-17 11:18 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (60.68 KB, patch)
2018-09-17 11:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (60.72 KB, patch)
2018-09-17 13:02 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (60.71 KB, patch)
2018-09-17 13:05 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-09-12 15:34:54 PDT 
Add support for HEVC codec types in Media Capabilities
Comment 1 Jer Noble 2018-09-12 16:25:06 PDT 
Created attachment 349595 [details]
Patch
Comment 2 Jer Noble 2018-09-12 16:36:51 PDT 
Created attachment 349596 [details]
Patch
Comment 3 Sam Weinig 2018-09-12 17:16:28 PDT 
Comment on attachment 349596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349596&action=review

> Source/WTF/ChangeLog:11
> +        * wtf/text/StringConversion.h: Added.

We already have a wtf/text/IntegerToStringConversion.h, so might I suggest naming this wtf/text/StringToIntegerConversion.h?

> Source/WTF/wtf/text/StringConversion.h:28
> +inline bool isCharacterAllowedInBase(UChar c, int base)

You probably want this (and the rest of the file) in the WTF namespace.
Comment 4 Sam Weinig 2018-09-12 17:17:38 PDT 
Comment on attachment 349596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349596&action=review

> Source/WTF/ChangeLog:3
> +        Add support for HEVC codec types in Media Capabilities

This patch does not seem to have anything to do with this.
Comment 5 EWS Watchlist 2018-09-12 18:43:50 PDT 
Comment on attachment 349596 [details]
Patch

Attachment 349596 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9197494

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 6 EWS Watchlist 2018-09-12 18:43:52 PDT 
Created attachment 349610 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 7 EWS Watchlist 2018-09-12 20:10:16 PDT 
Comment on attachment 349596 [details]
Patch

Attachment 349596 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9198433

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 8 EWS Watchlist 2018-09-12 20:10:18 PDT 
Created attachment 349616 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 Jer Noble 2018-09-17 10:46:11 PDT 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 349596 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349596&action=review
> 
> > Source/WTF/ChangeLog:11
> > +        * wtf/text/StringConversion.h: Added.
> 
> We already have a wtf/text/IntegerToStringConversion.h, so might I suggest
> naming this wtf/text/StringToIntegerConversion.h?

Good idea.

> > Source/WTF/wtf/text/StringConversion.h:28
> > +inline bool isCharacterAllowedInBase(UChar c, int base)
> 
> You probably want this (and the rest of the file) in the WTF namespace.

Will do.

(In reply to Sam Weinig from comment #4)
> Comment on attachment 349596 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349596&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        Add support for HEVC codec types in Media Capabilities
> 
> This patch does not seem to have anything to do with this.

Whoops, webkit-patch upload'd from the Source/WTF directory and missed the bulk of this patch. Will retry.
Comment 10 Jer Noble 2018-09-17 11:11:23 PDT 
Created attachment 349908 [details]
Patch
Comment 11 Jer Noble 2018-09-17 11:18:54 PDT 
Created attachment 349910 [details]
Patch
Comment 12 Jer Noble 2018-09-17 11:25:17 PDT 
Created attachment 349912 [details]
Patch
Comment 13 Eric Carlson 2018-09-17 12:57:39 PDT 
Comment on attachment 349912 [details]
Patch

r=me once the bots are happy with the patch
Comment 14 Jer Noble 2018-09-17 13:02:55 PDT 
Created attachment 349921 [details]
Patch for landing
Comment 15 Radar WebKit Bug Importer 2018-09-17 13:04:55 PDT 
<rdar://problem/44531065>
Comment 16 Jer Noble 2018-09-17 13:05:59 PDT 
Created attachment 349922 [details]
Patch for landing
Comment 17 WebKit Commit Bot 2018-09-17 16:24:29 PDT 
Comment on attachment 349922 [details]
Patch for landing

Clearing flags on attachment: 349922

Committed r236094: <https://trac.webkit.org/changeset/236094>
Comment 18 WebKit Commit Bot 2018-09-17 16:24:31 PDT 
All reviewed patches have been landed.  Closing bug.