Bug 189556 – [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Chris King]

WPEwebkit version 2.21.92 is currently failing to build on ARM architectures in Fedora, complaining about /builddir/build/BUILD/wpewebkit-2.21.92/Tools/wpe/backends/WindowViewBackend.cpp:610: undefined reference to `epoxy_eglMakeCurrent' and many other similar libepoxy things. Libepoxy is installed on the machines that WPE is building on, and the build succeeds on otherwise identical x86 and i686 machines.

Here is the summary of the failed 64bit ARM build (see build.log under the "output" section for the compilation): https://koji.fedoraproject.org/koji/taskinfo?taskID=29607609

And here is the summary of the failed 32 bit ARM build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29607612

[Michael Catanzaro]

Created attachment 349591 [details]
Patch

[Michael Catanzaro]

No reviews?

Adrian: you want this before releasing WPE 2.20.

[Adrian Perez]

Comment on attachment 349591 [details]
Patch

At any rate, linking to epoxy is the correct way to go because well,
the library *is* used after all. With my informal reviewer hat I say “r+”.

[Chris King]

I don't know if you want this info, but the patch makes the package properly build for me.

[Adrian Perez]

A quick theory on why this build failure happens in Fedora: it may
have to do with compiler specs, or something that is put in LDFLAGS
to avoid overlinking and/or lazy resolution (like “-Wl,--as-needed”
or “-Wl,-z,now” — which is *good* practice). Something like that
would explain why the library has to be explicitly listed.

Like I wrote in my previous comment: the *correct* thing is to always
list the library anyway, so I am very much favorable to landing the
patch.

[Adrian Perez]

(In reply to Chris King from comment #4)
> I don't know if you want this info, but the patch makes the package properly
> build for me.

Yes, knowing that this fixes the build for you on Fedora is valuable
information — thanks!

[WebKit Commit Bot]

Comment on attachment 349591 [details]
Patch

Clearing flags on attachment: 349591

Committed r236275: <https://trac.webkit.org/changeset/236275>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.