189553 – SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

RESOLVED FIXED 189553

SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

https://bugs.webkit.org/show_bug.cgi?id=189553

Summary SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

Jer Noble

Reported 2018-09-12 10:59:25 PDT

SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

Attachments
Patch (93.36 KB, patch) 2018-09-12 11:02 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (93.51 KB, patch) 2018-09-12 15:27 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.44 MB, application/zip) 2018-09-12 17:06 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.76 MB, application/zip) 2018-09-12 17:58 PDT, EWS Watchlist	no flags	Details
Patch (93.51 KB, patch) 2018-10-31 13:56 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (100.76 KB, patch) 2018-10-31 15:09 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (100.92 KB, patch) 2018-10-31 16:36 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (101.01 KB, patch) 2019-01-11 16:43 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (100.84 KB, patch) 2019-01-17 07:59 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (100.97 KB, patch) 2019-01-18 12:40 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (100.97 KB, patch) 2019-01-18 12:40 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2018-09-12 11:02:53 PDT

Created attachment 349561 [details] Patch

EWS Watchlist

Comment 2 2018-09-12 11:06:44 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Tim Horton

Comment 3 2018-09-12 11:57:11 PDT

Comment on attachment 349561 [details] Patch Can you make these all identical and add them to sync-feature-defines??? It's SO helpful.

Tim Horton

Comment 4 2018-09-12 11:57:42 PDT

(I realize they're not feature defines, maybe we can rename the script... sync-shared-xcconfigs?)

Jer Noble

Comment 5 2018-09-12 12:49:25 PDT

(In reply to Tim Horton from comment #3) > Comment on attachment 349561 [details] > Patch > > Can you make these all identical and add them to sync-feature-defines??? > It's SO helpful. > > (I realize they're not feature defines, maybe we can rename the script... > sync-shared-xcconfigs?) Well, all the SDKVariant.xcconfig files are identical. I'll look into it though!

Jer Noble

Comment 6 2018-09-12 15:27:57 PDT

Created attachment 349588 [details] Patch

EWS Watchlist

Comment 7 2018-09-12 17:06:15 PDT Comment hidden (obsolete)

Comment on attachment 349588 [details] Patch Attachment 349588 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9196542 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2018-09-12 17:06:17 PDT Comment hidden (obsolete)

Created attachment 349598 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 9 2018-09-12 17:57:58 PDT Comment hidden (obsolete)

Comment on attachment 349588 [details] Patch Attachment 349588 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9197323 New failing tests: accessibility/smart-invert-reference.html

EWS Watchlist

Comment 10 2018-09-12 17:58:00 PDT Comment hidden (obsolete)

Created attachment 349606 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Jer Noble

Comment 11 2018-10-31 13:56:34 PDT

Created attachment 353528 [details] Patch

Tim Horton

Comment 12 2018-10-31 14:29:20 PDT

Comment on attachment 353528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353528&action=review > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:2 > +#include "SDKVariant.xcconfign" I think you have an extra "n"

Tim Horton

Comment 13 2018-10-31 14:29:44 PDT

(In reply to Jer Noble from comment #5) > (In reply to Tim Horton from comment #3) > > Comment on attachment 349561 [details] > > Patch > > > > Can you make these all identical and add them to sync-feature-defines??? > > It's SO helpful. > > > > (I realize they're not feature defines, maybe we can rename the script... > > sync-shared-xcconfigs?) > > Well, all the SDKVariant.xcconfig files are identical. Right, that's literally the point. To make sure they stay that way. > I'll look into it though!

Jer Noble

Comment 14 2018-10-31 14:35:11 PDT

(In reply to Tim Horton from comment #12) > Comment on attachment 353528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353528&action=review > > > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:2 > > +#include "SDKVariant.xcconfign" > > I think you have an extra "n" Ack!

Jer Noble

Comment 15 2018-10-31 15:09:38 PDT

Created attachment 353536 [details] Patch

Tim Horton

Comment 16 2018-10-31 15:19:34 PDT

Comment on attachment 353536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353536&action=review > PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:43 > +EFFECTIVE_PLATFORM_NAME = $(EFFECTIVE_PLATFORM_NAME_ALTERNATE_$(WK_USE_ALTERNATE_PLATFORM_NAME) Isn't this missing a close paren and semicolon

Jer Noble

Comment 17 2018-10-31 16:29:28 PDT

(In reply to Tim Horton from comment #16) > Comment on attachment 353536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353536&action=review > > > PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:43 > > +EFFECTIVE_PLATFORM_NAME = $(EFFECTIVE_PLATFORM_NAME_ALTERNATE_$(WK_USE_ALTERNATE_PLATFORM_NAME) > > Isn't this missing a close paren and semicolon Apparently not, since that line is what controls the build directory and the build directory is set as you'd expect when you build with SDK_VARIANT=. But yes, I'll fix it.

Jer Noble

Comment 18 2018-10-31 16:36:35 PDT

Created attachment 353552 [details] Patch

Radar WebKit Bug Importer

Comment 19 2018-11-01 06:21:17 PDT

<rdar://problem/45727881>

Jer Noble

Comment 20 2019-01-11 16:43:07 PST

Created attachment 358965 [details] Patch

Tim Horton

Comment 21 2019-01-16 12:29:54 PST

Comment on attachment 358965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358965&action=review I don't love the new xcconfigs. > Tools/ChangeLog:22 > + SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds Double changelog > Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1 > +// Copyright (C) 2018 Apple Inc. All rights reserved. The year has changed

Jer Noble

Comment 22 2019-01-16 14:15:52 PST

(In reply to Tim Horton from comment #21) > Comment on attachment 358965 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358965&action=review > > I don't love the new xcconfigs. I'm hopeful we can unify all the "same for every subproject xcconfig" files into a smaller set of xcconfig files. > > Tools/ChangeLog:22 > > + SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds > > Double changelog Will fix. > > Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1 > > +// Copyright (C) 2018 Apple Inc. All rights reserved. > > The year has changed It's 2019 and I'm still writing 2018 on all my copyright statements.

Jer Noble

Comment 23 2019-01-17 07:59:04 PST

Created attachment 359375 [details] Patch for landing

WebKit Commit Bot

Comment 24 2019-01-17 12:46:11 PST

Comment on attachment 359375 [details] Patch for landing Clearing flags on attachment: 359375 Committed r240124: <https://trac.webkit.org/changeset/240124>

WebKit Commit Bot

Comment 25 2019-01-17 12:46:13 PST

All reviewed patches have been landed. Closing bug.

Truitt Savell

Comment 26 2019-01-17 16:43:33 PST

Reverted r240124 for reason: This commit broke an internal build. Committed r240136: <https://trac.webkit.org/changeset/240136>

Jer Noble

Comment 27 2019-01-18 12:40:20 PST

Created attachment 359526 [details] Patch for landing

Jer Noble

Comment 28 2019-01-18 12:40:43 PST

Created attachment 359527 [details] Patch for landing

WebKit Commit Bot

Comment 29 2019-01-18 14:53:56 PST

Comment on attachment 359527 [details] Patch for landing Clearing flags on attachment: 359527 Committed r240176: <https://trac.webkit.org/changeset/240176>

WebKit Commit Bot

Comment 30 2019-01-18 14:53:58 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Jer Noble

Reported

2018-09-12 10:59 PDT

Modified

2019-01-18 14:53 PST History

CC List

17 users Show

URL

Keywords InRadar

Depends on

Blocks