SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
Created attachment 349561 [details] Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment on attachment 349561 [details] Patch Can you make these all identical and add them to sync-feature-defines??? It's SO helpful.
(I realize they're not feature defines, maybe we can rename the script... sync-shared-xcconfigs?)
(In reply to Tim Horton from comment #3) > Comment on attachment 349561 [details] > Patch > > Can you make these all identical and add them to sync-feature-defines??? > It's SO helpful. > > (I realize they're not feature defines, maybe we can rename the script... > sync-shared-xcconfigs?) Well, all the SDKVariant.xcconfig files are identical. I'll look into it though!
Created attachment 349588 [details] Patch
Comment on attachment 349588 [details] Patch Attachment 349588 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9196542 Number of test failures exceeded the failure limit.
Created attachment 349598 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 349588 [details] Patch Attachment 349588 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9197323 New failing tests: accessibility/smart-invert-reference.html
Created attachment 349606 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 353528 [details] Patch
Comment on attachment 353528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353528&action=review > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:2 > +#include "SDKVariant.xcconfign" I think you have an extra "n"
(In reply to Jer Noble from comment #5) > (In reply to Tim Horton from comment #3) > > Comment on attachment 349561 [details] > > Patch > > > > Can you make these all identical and add them to sync-feature-defines??? > > It's SO helpful. > > > > (I realize they're not feature defines, maybe we can rename the script... > > sync-shared-xcconfigs?) > > Well, all the SDKVariant.xcconfig files are identical. Right, that's literally the point. To make sure they stay that way. > I'll look into it though!
(In reply to Tim Horton from comment #12) > Comment on attachment 353528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353528&action=review > > > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:2 > > +#include "SDKVariant.xcconfign" > > I think you have an extra "n" Ack!
Created attachment 353536 [details] Patch
Comment on attachment 353536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353536&action=review > PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:43 > +EFFECTIVE_PLATFORM_NAME = $(EFFECTIVE_PLATFORM_NAME_ALTERNATE_$(WK_USE_ALTERNATE_PLATFORM_NAME) Isn't this missing a close paren and semicolon
(In reply to Tim Horton from comment #16) > Comment on attachment 353536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353536&action=review > > > PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:43 > > +EFFECTIVE_PLATFORM_NAME = $(EFFECTIVE_PLATFORM_NAME_ALTERNATE_$(WK_USE_ALTERNATE_PLATFORM_NAME) > > Isn't this missing a close paren and semicolon Apparently not, since that line is what controls the build directory and the build directory is set as you'd expect when you build with SDK_VARIANT=. But yes, I'll fix it.
Created attachment 353552 [details] Patch
<rdar://problem/45727881>
Created attachment 358965 [details] Patch
Comment on attachment 358965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358965&action=review I don't love the new xcconfigs. > Tools/ChangeLog:22 > + SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds Double changelog > Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1 > +// Copyright (C) 2018 Apple Inc. All rights reserved. The year has changed
(In reply to Tim Horton from comment #21) > Comment on attachment 358965 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358965&action=review > > I don't love the new xcconfigs. I'm hopeful we can unify all the "same for every subproject xcconfig" files into a smaller set of xcconfig files. > > Tools/ChangeLog:22 > > + SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds > > Double changelog Will fix. > > Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1 > > +// Copyright (C) 2018 Apple Inc. All rights reserved. > > The year has changed It's 2019 and I'm still writing 2018 on all my copyright statements.
Created attachment 359375 [details] Patch for landing
Comment on attachment 359375 [details] Patch for landing Clearing flags on attachment: 359375 Committed r240124: <https://trac.webkit.org/changeset/240124>
All reviewed patches have been landed. Closing bug.
Reverted r240124 for reason: This commit broke an internal build. Committed r240136: <https://trac.webkit.org/changeset/240136>
Created attachment 359526 [details] Patch for landing
Created attachment 359527 [details] Patch for landing
Comment on attachment 359527 [details] Patch for landing Clearing flags on attachment: 359527 Committed r240176: <https://trac.webkit.org/changeset/240176>