Bug 189549 - getComputedStyle doesn't absolutize percentages in sticky positioning
Summary: getComputedStyle doesn't absolutize percentages in sticky positioning
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
Keywords: InRadar
Depends on:
Reported: 2018-09-12 08:19 PDT by Oriol Brufau
Modified: 2019-05-03 06:24 PDT (History)
11 users (show)

See Also:

Patch (72.10 KB, patch)
2019-05-02 23:25 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.67 MB, application/zip)
2019-05-03 01:04 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2018-09-12 08:19:32 PDT
Run this code for some element that generates boxes:

element.style.position = "-webkit-sticky";
element.style.top = "10%";

Actual value: "10%"
Expected: the percentage should be absolutized into a length
Comment 1 Emilio Cobos Álvarez (:emilio) 2018-09-16 11:17:01 PDT
Beware of other browsers not being interoperable here, see: https://github.com/w3c/csswg-drafts/issues/3115
Comment 2 Joonghun Park 2019-04-30 03:49:02 PDT
* Corresponding blink bug:
Comment 3 Joonghun Park 2019-05-02 23:25:47 PDT
Created attachment 368906 [details]
Comment 4 Joonghun Park 2019-05-03 00:32:20 PDT
Hi, Could this change be reviewed?
Comment 5 EWS Watchlist 2019-05-03 01:04:06 PDT
Comment on attachment 368906 [details]

Attachment 368906 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12080674

New failing tests:
Comment 6 EWS Watchlist 2019-05-03 01:04:09 PDT
Created attachment 368912 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 7 Joonghun Park 2019-05-03 01:20:06 PDT
It seems that win-ews is unstable currently seeing https://webkit-queues.webkit.org/queue-status/win-ews.

So the win-ews's failure result could be ignored I guess.
Comment 8 Antti Koivisto 2019-05-03 04:37:47 PDT
Comment on attachment 368906 [details]

Comment 9 WebKit Commit Bot 2019-05-03 06:20:03 PDT
Comment on attachment 368906 [details]

Clearing flags on attachment: 368906

Committed r244906: <https://trac.webkit.org/changeset/244906>
Comment 10 WebKit Commit Bot 2019-05-03 06:20:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-05-03 06:24:07 PDT