Bug 189546 – Add enterkeyhint support

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[David Tapuska]

Pull request https://github.com/whatwg/html/pull/3538 adds support for enterkeylabel.

This provides a mechanism to configure the enter key icon/label on the web.

Please consider supporting this in Safari.

[David Tapuska]

s/enterkeylabel/enterkeyhint

[David Tapuska]

Example:
http://output.jsbin.com/mukira

[Radar WebKit Bug Importer]

<rdar://problem/51021148>

[Wenson Hsieh]

Created attachment 382150 [details]
Patch

[Wenson Hsieh]

Created attachment 382151 [details]
Fix GTK/WPE builds

[WebKit Commit Bot]

Comment on attachment 382151 [details]
Fix GTK/WPE builds

Rejecting attachment 382151 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 382151, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382151&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189546&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 382151 from bug 189546.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382151
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 10 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Headers.cmake
patching file Source/WebKit/Shared/FocusedElementInformation.cpp
patching file Source/WebKit/Shared/FocusedElementInformation.h
patching file Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
patching file Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Hunk #1 succeeded at 1032 (offset 1 line).
Hunk #2 FAILED at 1460.
Hunk #3 succeeded at 2557 (offset 1 line).
Hunk #4 succeeded at 3137 (offset 1 line).
Hunk #5 succeeded at 4568 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj.rej
patching file Tools/TestWebKitAPI/Tests/ios/EnterKeyHintTests.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13188930

[Wenson Hsieh]

Landed: https://trac.webkit.org/changeset/251720/webkit.