RESOLVED FIXED 189543
[GTK] Always prints in portrait when landscape is requested 
https://bugs.webkit.org/show_bug.cgi?id=189543
Summary [GTK] Always prints in portrait when landscape is requested
Bastien Nocera
Reported 2018-09-12 05:43:30 PDT
Tested with epiphany and MiniBrowser. webkit2gtk3-2.20.5-1.fc28.x86_64 epiphany-3.28.3.1-1.fc28.x86_64 This happens with every page I try to print. I have to use Firefox to print in landscape mode so that data won't be missing from the printout.
Attachments
Patch (1.87 KB, patch)
2018-09-19 07:43 PDT, Tomas Popela 		mcatanzaro: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2018-09-19 07:43:58 PDT
Created attachment 350114 [details] Patch
Adrian Perez
Comment 2 2018-09-19 09:42:30 PDT
Comment on attachment 350114 [details] Patch This LGTM (informal r+!)
WebKit Commit Bot
Comment 3 2018-09-20 00:11:01 PDT
Comment on attachment 350114 [details] Patch Rejecting attachment 350114 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 350114, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/9278329
Carlos Garcia Campos
Comment 4 2018-09-20 00:16:53 PDT
Committed r236245: <https://trac.webkit.org/changeset/236245>
Note You need to log in before you can comment on or make changes to this bug.