Bug 189532 – Fix color stop blending in conic gradients for stops past 1

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Fix color stop blending for stops past 1

[Megan Gardner]

<rdar://problem/44158221>

[Megan Gardner]

Created attachment 349495 [details]
Patch

[Megan Gardner]

<rdar://problem/44158221>

[EWS Watchlist]

Comment on attachment 349495 [details]
Patch

Attachment 349495 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9182551

New failing tests:
fast/gradients/conic-repeating-last-stop.html

[EWS Watchlist]

Created attachment 349503 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349495 [details]
Patch

Attachment 349495 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9184369

New failing tests:
fast/gradients/conic-repeating-last-stop.html

[EWS Watchlist]

Created attachment 349510 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349495 [details]
Patch

Attachment 349495 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9183791

New failing tests:
fast/gradients/conic-repeating-last-stop.html

[EWS Watchlist]

Created attachment 349512 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 349495 [details]
Patch

Attachment 349495 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9185225

New failing tests:
fast/gradients/conic-repeating-last-stop.html

[EWS Watchlist]

Created attachment 349516 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349495 [details]
Patch

Attachment 349495 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9186380

New failing tests:
fast/gradients/conic-repeating-last-stop.html

[EWS Watchlist]

Created attachment 349521 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Megan Gardner]

Created attachment 349569 [details]
Patch

[Megan Gardner]

Created attachment 349577 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 349577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349577&action=review

Make sure the EWS is green before landing.

> Source/WebCore/ChangeLog:12
> +        Test: fast/gradients/conic-repeating-last-stop.html
> +
> +        Calculation was wrong, fixed it, and wrote a test that failed
> +        without the change, and passes with it.

We normally put the Test: line after the description.

[Megan Gardner]

Created attachment 349580 [details]
Patch for landing

[Megan Gardner]

Created attachment 349582 [details]
Patch for landing

[Megan Gardner]

Created attachment 349605 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 349605 [details]
Patch for landing

Clearing flags on attachment: 349605

Committed r235999: <https://trac.webkit.org/changeset/235999>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.