Bug 189530 - [Curl] Bug fix on some inaccurate values in NetworkLoadMetrics.
Summary: [Curl] Bug fix on some inaccurate values in NetworkLoadMetrics.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-11 16:47 PDT by Basuke Suzuki
Modified: 2018-09-14 17:47 PDT (History)
10 users (show)

See Also:

Attachments
PATCH (14.28 KB, patch)
2018-09-14 15:17 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
PATCH (14.34 KB, patch)
2018-09-14 15:31 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-09-11 16:47:06 PDT 
The timing information curl returns is calculated based on the curl_ease_perform(), which is invoked in background thread. The real metrics should be started at the timing of request handler (CurlRequest) started timing.
Comment 1 Basuke Suzuki 2018-09-14 15:17:47 PDT 
Created attachment 349815 [details]
PATCH

responseEnd was implemented correctly. Also initial delay caused by the gap from main thread to curl thread was adjusted.
Comment 2 Basuke Suzuki 2018-09-14 15:31:13 PDT 
Created attachment 349819 [details]
PATCH
Comment 3 WebKit Commit Bot 2018-09-14 17:46:54 PDT 
Comment on attachment 349819 [details]
PATCH

Clearing flags on attachment: 349819

Committed r236029: <https://trac.webkit.org/changeset/236029>
Comment 4 WebKit Commit Bot 2018-09-14 17:46:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-14 17:47:38 PDT 
<rdar://problem/44475694>