Make GraphicsLayers ref-counted, so their tree can persist when disconnected from RenderLayerBackings
Created attachment 349449 [details] Patch
Comment on attachment 349449 [details] Patch Please remove the logging.
<rdar://problem/44357032>
Created attachment 349460 [details] Patch
Created attachment 349464 [details] Patch
Created attachment 349475 [details] Patch
Created attachment 349477 [details] Patch
Created attachment 349483 [details] Patch
Created attachment 349485 [details] Patch
Comment on attachment 349449 [details] Patch Attachment 349449 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9179534 New failing tests: compositing/scrolling/touch-scroll-to-clip.html
Created attachment 349487 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 349488 [details] Patch
Created attachment 349498 [details] Patch
Created attachment 349504 [details] Patch
Created attachment 349506 [details] Patch
Created attachment 349507 [details] Patch
Created attachment 349519 [details] Patch
Created attachment 349520 [details] Patch
Created attachment 349522 [details] Patch
Created attachment 349525 [details] Patch
Comment on attachment 349525 [details] Patch Attachment 349525 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9188407 New failing tests: compositing/scrolling/touch-scroll-to-clip.html
Created attachment 349529 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 349525 [details] Patch Attachment 349525 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9188673 New failing tests: pageoverlay/overlay-remove-reinsert-view.html
Created attachment 349530 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 349547 [details] Patch
Comment on attachment 349547 [details] Patch Attachment 349547 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9192253 New failing tests: pageoverlay/overlay-remove-reinsert-view.html
Created attachment 349556 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 349547 [details] Patch Attachment 349547 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9192538 New failing tests: compositing/scrolling/touch-scroll-to-clip.html
Created attachment 349559 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
https://trac.webkit.org/r235953
Reverted r235953 for reason: Caused layout test crashes under GuardMalloc. Committed r235979: <https://trac.webkit.org/changeset/235979>
(In reply to Ryan Haddad from comment #31) > Reverted r235953 for reason: > > Caused layout test crashes under GuardMalloc. > > Committed r235979: <https://trac.webkit.org/changeset/235979> Strangely, rolling this patch out also fixed 8 leaks on our internal leaks bot?!
(In reply to David Kilzer (:ddkilzer) from comment #32) > (In reply to Ryan Haddad from comment #31) > > Reverted r235953 for reason: > > > > Caused layout test crashes under GuardMalloc. > > > > Committed r235979: <https://trac.webkit.org/changeset/235979> > > Strangely, rolling this patch out also fixed 8 leaks on our internal leaks > bot?! Oops, I meant "static analyzer issues", not "leaks" above.
This also seems to have caused compositing/scrolling/touch-scroll-to-clip.html to fail on iOS Simulator: --- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/compositing/scrolling/touch-scroll-to-clip-expected.txt +++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/compositing/scrolling/touch-scroll-to-clip-actual.txt @@ -9,7 +9,18 @@ (GraphicsLayer (position 8.00 8.00) (bounds 320.00 440.00) - (children 1 + (children 2 + (GraphicsLayer + (offsetFromRenderer width=-20 height=-20) + (position 20.00 20.00) + (bounds 280.00 400.00) + (children 1 + (GraphicsLayer + (offsetFromRenderer width=20 height=20) + (bounds 280.00 500.00) + ) + ) + ) (GraphicsLayer (offsetFromRenderer width=20 height=20) (position 20.00 20.00) https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r235978%20(7401)/results.html
Created attachment 349720 [details] Patch
https://trac.webkit.org/changeset/236016/webkit
*** Bug 189572 has been marked as a duplicate of this bug. ***