[Curl] Limit capturing extra metrics for Web Inspector when not required.

[Basuke Suzuki]

Respect the value of NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics() to reduce the process time when they are not needed.

[Basuke Suzuki]

Created attachment 349903 [details]
PATCH

[Alex Christensen]

Comment on attachment 349903 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=349903&action=review

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:140
> +    auto curlRequest = CurlRequest::create(request, *this, CurlRequest::ShouldSuspend::Yes);
> +    curlRequest->setCaptureExtraNetworkLoadMetricsEnabled(shouldCaptureExtraNetworkLoadMetrics());

This should be a constructor parameter.  If it's annoying use a default value.

[Basuke Suzuki]

Created attachment 349959 [details]
PATCH

Thanks for the review. I remove setter and move that to the constructor argument.

[Alex Christensen]

Comment on attachment 349959 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=349959&action=review

> Source/WebCore/platform/network/curl/CurlRequest.h:112
> +    CurlRequest(const ResourceRequest&, CurlRequestClient*, bool shouldSuspend, bool enableMultipart, bool captureExtendedMetrics, MessageQueue<Function<void()>>*);

It would be more readable to just pass the enums here, too.

[Basuke Suzuki]

Created attachment 350053 [details]
PATCH

[Basuke Suzuki]

Comment on attachment 350053 [details]
PATCH

Sorry, I've submitted a different patch file. This one is the right one.

[WebKit Commit Bot]

Comment on attachment 350053 [details]
PATCH

Clearing flags on attachment: 350053

Committed r236156: <https://trac.webkit.org/changeset/236156>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44577426>