Bug 189506 – Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Pablo Saavedra]

the use of `m_pipStandbyElement` must be guarded with ENABLE(VIDEO), otherwise a compilation error occurs with the VIDEO feature turned off


m_pipStandbyElement is only defined in Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h when ENABLE(VIDEO):


```
#if ENABLE(VIDEO)
    RefPtr<WebCore::HTMLVideoElement> m_pipStandbyElement;
#endif
```

[Pablo Saavedra]

Created attachment 349412 [details]
patch

[Tim Horton]

Comment on attachment 349412 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349412&action=review

> Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102
> +#if ENABLE(VIDEO)

!ENABLE(VIDEO) knows what HTMLVideoElement is, though??

[Pablo Saavedra]

Related with https://bugs.webkit.org/show_bug.cgi?id=181338

[WebKit Commit Bot]

Comment on attachment 349412 [details]
patch

Clearing flags on attachment: 349412

Committed r235906: <https://trac.webkit.org/changeset/235906>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44350074>

[Pablo Saavedra]

(In reply to Tim Horton from comment #2)
> Comment on attachment 349412 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349412&action=review
> 
> > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102
> > +#if ENABLE(VIDEO)
> 
> !ENABLE(VIDEO) knows what HTMLVideoElement is, though??

(In reply to Tim Horton from comment #2)
> Comment on attachment 349412 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349412&action=review
> 
> > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102
> > +#if ENABLE(VIDEO)
> 
> !ENABLE(VIDEO) knows what HTMLVideoElement is, though??

WebCore/html/HTMLVideoElement.h

Yes, it seems HTMLVideoElement is declared in the Webcore namespace in the top `WebKit/WebProcess/FullScreen/WebFullScreenManager.h`

namespace WebCore {
class IntRect;
class Element;
class GraphicsLayer;
class HTMLVideoElement;
}

Since HTMLVideoElement is not actually used in a statement but in a declaration in the signature of the function is the reason why is valid.