Bug 189500 - Add missing #if ENABLE(VIDEO) Page.cpp and Page.h
Summary: Add missing #if ENABLE(VIDEO) Page.cpp and Page.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-11 08:13 PDT by Pablo Saavedra
Modified: 2018-09-11 09:18 PDT (History)
7 users (show)

See Also:


Attachments
patch (3.46 KB, patch)
2018-09-11 08:20 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2018-09-11 08:13:54 PDT
playbackControlsManagerUpdateTimerFired and m_playbackControlsManagerUpdateTimer must be guarded with ENABLE(VIDEO), otherwise the following error occurs with the VIDEO feature turned off

    error: 'MediaElementSession' has not been declared

in L1520 Source/WebCore/page/Page.cpp
Comment 1 Pablo Saavedra 2018-09-11 08:20:19 PDT
Created attachment 349395 [details]
patch
Comment 2 WebKit Commit Bot 2018-09-11 09:07:52 PDT
Comment on attachment 349395 [details]
patch

Clearing flags on attachment: 349395

Committed r235895: <https://trac.webkit.org/changeset/235895>
Comment 3 WebKit Commit Bot 2018-09-11 09:07:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-09-11 09:08:23 PDT
<rdar://problem/44344299>
Comment 5 youenn fablet 2018-09-11 09:18:06 PDT
Comment on attachment 349395 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349395&action=review

> Source/WebCore/ChangeLog:8
> +          error: 'MediaElementSession' has not been declared

These explanations should be between "Reviewed by NOBODY (OOPS!)." and the filename list.

> Source/WebCore/page/Page.cpp:1525
>  void Page::playbackControlsManagerUpdateTimerFired()

Would it be ok to just #if ENABLE(VIDEO) inside Page::playbackControlsManagerUpdateTimerFired?
It might remove the need for the other #if/#endif