playbackControlsManagerUpdateTimerFired and m_playbackControlsManagerUpdateTimer must be guarded with ENABLE(VIDEO), otherwise the following error occurs with the VIDEO feature turned off error: 'MediaElementSession' has not been declared in L1520 Source/WebCore/page/Page.cpp
Created attachment 349395 [details] patch
Comment on attachment 349395 [details] patch Clearing flags on attachment: 349395 Committed r235895: <https://trac.webkit.org/changeset/235895>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44344299>
Comment on attachment 349395 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=349395&action=review > Source/WebCore/ChangeLog:8 > + error: 'MediaElementSession' has not been declared These explanations should be between "Reviewed by NOBODY (OOPS!)." and the filename list. > Source/WebCore/page/Page.cpp:1525 > void Page::playbackControlsManagerUpdateTimerFired() Would it be ok to just #if ENABLE(VIDEO) inside Page::playbackControlsManagerUpdateTimerFired? It might remove the need for the other #if/#endif