Bug 189494 - Update shadow DOM and custom elements tests
Summary: Update shadow DOM and custom elements tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-10 20:36 PDT by Ryosuke Niwa
Modified: 2018-09-10 21:00 PDT (History)
4 users (show)

See Also:

Attachments
Updated the tests (78.06 KB, patch)
2018-09-10 20:39 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Added the missing expected.txt (78.87 KB, patch)
2018-09-10 20:42 PDT, Ryosuke Niwa 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-09-10 20:36:11 PDT 
Update shadow DOM and custom elements tests
Comment 1 Ryosuke Niwa 2018-09-10 20:39:25 PDT 
Created attachment 349374 [details]
Updated the tests
Comment 2 Ryosuke Niwa 2018-09-10 20:42:53 PDT 
Created attachment 349375 [details]
Added the missing expected.txt
Comment 3 youenn fablet 2018-09-10 20:46:49 PDT 
Comment on attachment 349375 [details]
Added the missing expected.txt

View in context: https://bugs.webkit.org/attachment.cgi?id=349375&action=review

> LayoutTests/TestExpectations:2240
> +webkit.org/b/189493 [ Debug ] imported/w3c/web-platform-tests/shadow-dom/layout-slot-no-longer-assigned.html [ Crash ]

Should probably be skipped until crash is fixed.
Comment 4 Ryosuke Niwa 2018-09-10 20:51:00 PDT 
(In reply to youenn fablet from comment #3)
> Comment on attachment 349375 [details]
> Added the missing expected.txt
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349375&action=review
> 
> > LayoutTests/TestExpectations:2240
> > +webkit.org/b/189493 [ Debug ] imported/w3c/web-platform-tests/shadow-dom/layout-slot-no-longer-assigned.html [ Crash ]
> 
> Should probably be skipped until crash is fixed.

Sure, will do that.
Comment 5 Ryosuke Niwa 2018-09-10 20:59:43 PDT 
Committed r235881: <https://trac.webkit.org/changeset/235881>
Comment 6 Radar WebKit Bug Importer 2018-09-10 21:00:46 PDT 
<rdar://problem/44329579>