WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189491
Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance tests part 3
https://bugs.webkit.org/show_bug.cgi?id=189491
Summary
Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance t...
Justin Fan
Reported
2018-09-10 18:31:09 PDT
Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance tests part 3
Attachments
Patch
(132.48 KB, patch)
2018-09-10 18:34 PDT
,
Justin Fan
no flags
Details
Formatted Diff
Diff
Patch
(132.46 KB, patch)
2018-09-11 13:05 PDT
,
Justin Fan
no flags
Details
Formatted Diff
Diff
Patch
(132.46 KB, patch)
2018-09-11 13:06 PDT
,
Justin Fan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-09-10 18:33:29 PDT
<
rdar://problem/44326194
>
Justin Fan
Comment 2
2018-09-10 18:34:56 PDT
Created
attachment 349368
[details]
Patch
Dean Jackson
Comment 3
2018-09-11 12:53:26 PDT
Comment on
attachment 349368
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=349368&action=review
> LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js:53 > + list("[ " + resultNum + ": PASS ] " + msg, "green");
The modern JS way to do these strings is: `[ ${resultNum}: PASS ] ${msg}`
Justin Fan
Comment 4
2018-09-11 13:05:01 PDT
Created
attachment 349428
[details]
Patch
Justin Fan
Comment 5
2018-09-11 13:05:31 PDT
(In reply to Dean Jackson from
comment #3
)
> Comment on
attachment 349368
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=349368&action=review
> > > LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js:53 > > + list("[ " + resultNum + ": PASS ] " + msg, "green"); > > The modern JS way to do these strings is: > > `[ ${resultNum}: PASS ] ${msg}`
Cool, Thanks!
Justin Fan
Comment 6
2018-09-11 13:06:24 PDT
Created
attachment 349430
[details]
Patch
WebKit Commit Bot
Comment 7
2018-09-11 14:35:31 PDT
Comment on
attachment 349430
[details]
Patch Clearing flags on attachment: 349430 Committed
r235913
: <
https://trac.webkit.org/changeset/235913
>
WebKit Commit Bot
Comment 8
2018-09-11 14:35:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug