Bug 189491 - Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance tests part 3
Summary: Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-10 18:31 PDT by Justin Fan
Modified: 2018-09-11 14:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (132.48 KB, patch)
2018-09-10 18:34 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (132.46 KB, patch)
2018-09-11 13:05 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (132.46 KB, patch)
2018-09-11 13:06 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-09-10 18:31:09 PDT 
Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance tests part 3
Comment 1 Radar WebKit Bug Importer 2018-09-10 18:33:29 PDT 
<rdar://problem/44326194>
Comment 2 Justin Fan 2018-09-10 18:34:56 PDT 
Created attachment 349368 [details]
Patch
Comment 3 Dean Jackson 2018-09-11 12:53:26 PDT 
Comment on attachment 349368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349368&action=review

> LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js:53
> +        list("[ " + resultNum + ": PASS ] " + msg, "green");

The modern JS way to do these strings is:

`[ ${resultNum}: PASS ] ${msg}`
Comment 4 Justin Fan 2018-09-11 13:05:01 PDT 
Created attachment 349428 [details]
Patch
Comment 5 Justin Fan 2018-09-11 13:05:31 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 349368 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349368&action=review
> 
> > LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js:53
> > +        list("[ " + resultNum + ": PASS ] " + msg, "green");
> 
> The modern JS way to do these strings is:
> 
> `[ ${resultNum}: PASS ] ${msg}`

Cool, Thanks!
Comment 6 Justin Fan 2018-09-11 13:06:24 PDT 
Created attachment 349430 [details]
Patch
Comment 7 WebKit Commit Bot 2018-09-11 14:35:31 PDT 
Comment on attachment 349430 [details]
Patch

Clearing flags on attachment: 349430

Committed r235913: <https://trac.webkit.org/changeset/235913>
Comment 8 WebKit Commit Bot 2018-09-11 14:35:32 PDT 
All reviewed patches have been landed.  Closing bug.