Bug 189486 – Header parsing for experimental and internal debug features

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Header parsing for experimental and internal debug features

[Radar WebKit Bug Importer]

<rdar://problem/44320618>

[Dean Jackson]

Relies on https://bugs.webkit.org/show_bug.cgi?id=189442

[Dean Jackson]

Created attachment 349340 [details]
Patch

[Dean Jackson]

Created attachment 349497 [details]
Patch

[EWS Watchlist]

Comment on attachment 349497 [details]
Patch

Attachment 349497 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9182425

New failing tests:
webanimations/accelerated-transition-interrupted-on-composited-element.html

[EWS Watchlist]

Created attachment 349501 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349497 [details]
Patch

Attachment 349497 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9183884

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 349511 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 349497 [details]
Patch

Attachment 349497 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9185205

New failing tests:
webanimations/accelerated-transition-interrupted-on-composited-element.html

[EWS Watchlist]

Created attachment 349515 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349497 [details]
Patch

Attachment 349497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9185483

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 349517 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Dean Jackson]

Committed r235948: <https://trac.webkit.org/changeset/235948>

[Truitt Savell]

This revision https://trac.webkit.org/changeset/235948/webkit

has caused over 100 test failures: https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r235948%20(7382)/results.html

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/7382

Is this a quick fix?

[Truitt Savell]

The test edited in https://trac.webkit.org/changeset/235964/webkit 

is a constant image failure

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Fanimations%2Fduplicate-keys.html

Diff:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r235970%20(11641)/legacy-animation-engine/animations/duplicate-keys-diffs.html

Looks like the image has accidentally been shifted up on the page.

[Truitt Savell]

This test: fast/animation/css-animation-resuming-when-visible-with-style-change2.html
is highly flakey after https://trac.webkit.org/changeset/235948/webkit

confirmed flakiness using command:
run-webkit-tests --root testbuild-235948 fast/animation/css-animation-resuming-when-visible-with-style-change2.html --iterations 100 -f

running this command on r235947 yields no failures. 

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fanimation%2Fcss-animation-resuming-when-visible-with-style-change2.html

Diff:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r235973%20(6728)/fast/animation/css-animation-resuming-when-visible-with-style-change2-pretty-diff.html