Bug 189482 - Regression(PSON): "Swipe back" snapshot is missing when navigating back cross-process
Summary: Regression(PSON): "Swipe back" snapshot is missing when navigating back cross...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 190314
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-10 14:20 PDT by Chris Dumez
Modified: 2018-10-05 10:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.47 KB, patch)
2018-09-11 10:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-09-10 14:20:30 PDT 
"Swipe back" snapshot is missing/blank when navigating back cross-process (due to process swap on navigation).
Comment 1 Radar WebKit Bug Importer 2018-09-10 14:21:25 PDT 
<rdar://problem/44317222>
Comment 2 Tim Horton 2018-09-10 14:29:58 PDT 
This is actually /slightly/ surprising, because the UI process owns the snapshots. But I'm sure you'll have a patch in 5 minutes.
Comment 3 Chris Dumez 2018-09-10 16:25:50 PDT 
A snapshot is taken and saved on the WebBackForwardListItem. However, it is blank. I believe it is likely the snapshot is taken too late after we've already reset some WebPageProxy state due to process swapping.
Comment 4 Chris Dumez 2018-09-10 16:27:24 PDT 
0x7febfc84e418 - WebPageProxy::continueNavigationInNewProcess()
0x7febfc84e418 - WebPageProxy::reattachToWebProcess()
0x7febfc84e418 - WebPageProxy::takeViewSnapshot()

We've already reattached the the new WebProcess at the time we take the snapshot.
Comment 5 Chris Dumez 2018-09-11 10:00:44 PDT 
Created attachment 349404 [details]
Patch
Comment 6 Geoffrey Garen 2018-09-11 10:14:28 PDT 
Comment on attachment 349404 [details]
Patch

We know we need to fix the content disappearing / flashing problem before we enable PSON, so it's a little weird to do this as a stopgap in the meantime -- but I also think it's harmless, and nice to get one bug out of the list.
Comment 7 WebKit Commit Bot 2018-09-11 10:42:37 PDT 
Comment on attachment 349404 [details]
Patch

Clearing flags on attachment: 349404

Committed r235898: <https://trac.webkit.org/changeset/235898>
Comment 8 WebKit Commit Bot 2018-09-11 10:42:38 PDT 
All reviewed patches have been landed.  Closing bug.