Bug 189478 – Expose a few WebPlaybackControlsManager-driven PIP APIs to clients

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

Expose a few WebPlaybackControlsManager-driven PIP APIs to clients.

[Matt Rajca]

<rdar://problem/44312650>

[Matt Rajca]

Created attachment 349349 [details]
Patch

[Matt Rajca]

Created attachment 349361 [details]
Patch

[Matt Rajca]

Created attachment 349402 [details]
Patch

[Eric Carlson]

Comment on attachment 349402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349402&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1226
> +bool WebViewImpl::isPictureInPictureActive()
> +{
> +    if (!m_playbackControlsManager)
> +        return false;
> +
> +    return [m_playbackControlsManager isPictureInPictureActive];
> +}
> +
> +void WebViewImpl::togglePictureInPicture()
> +{
> +    [m_playbackControlsManager togglePictureInPicture];
> +}

Nit: do you need to NULL-test m_playbackControlsManager in one method but not the other?

[Matt Rajca]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 349402 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349402&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1226
> > +bool WebViewImpl::isPictureInPictureActive()
> > +{
> > +    if (!m_playbackControlsManager)
> > +        return false;
> > +
> > +    return [m_playbackControlsManager isPictureInPictureActive];
> > +}
> > +
> > +void WebViewImpl::togglePictureInPicture()
> > +{
> > +    [m_playbackControlsManager togglePictureInPicture];
> > +}
> 
> Nit: do you need to NULL-test m_playbackControlsManager in one method but
> not the other?

Nope, simplified ::isPictureInPictureActive to avoid the nil check since messaging a nil Obj-C object will result in `NO`.

[Matt Rajca]

Committed r235944: <https://trac.webkit.org/changeset/235944>