Bug 189469 - Try to fix the iOSMac build
Summary: Try to fix the iOSMac build
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2018-09-10 00:06 PDT by Tim Horton
Modified: 2018-09-10 13:58 PDT (History)
7 users (show)

See Also:

Patch (10.65 KB, patch)
2018-09-10 00:06 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (10.70 KB, patch)
2018-09-10 11:54 PDT, Tim Horton
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-09-10 00:06:01 PDT
Try to fix the iOSMac build
Comment 1 Tim Horton 2018-09-10 00:06:34 PDT
Created attachment 349297 [details]
Comment 2 David Kilzer (:ddkilzer) 2018-09-10 09:06:08 PDT
Comment on attachment 349297 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=349297&action=review

> Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm:85
> +    Vector<PluginModuleInfo> plugins = WebKit::toImpl(contextRef)->pluginInfoStore().plugins();

In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource14-mm.mm:5:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm:85:12: error: unknown type name 'PluginModuleInfo'; did you mean 'WebKit::PluginModuleInfo'?
    Vector<PluginModuleInfo> plugins = WebKit::toImpl(contextRef)->pluginInfoStore().plugins();
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource14-mm.mm:5:
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm:40:
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebProcessPool.h:30:
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:30:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:71:8: note: 'WebKit::PluginModuleInfo' declared here
struct PluginModuleInfo;
1 error generated.
Comment 3 Tim Horton 2018-09-10 11:54:34 PDT
Created attachment 349319 [details]
Comment 4 WebKit Commit Bot 2018-09-10 13:47:26 PDT
Comment on attachment 349319 [details]

Rejecting attachment 349319 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 349319, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9163894
Comment 5 Tim Horton 2018-09-10 13:57:13 PDT
Comment 6 Radar WebKit Bug Importer 2018-09-10 13:58:32 PDT