NEW 189466
Add bindings support for representing attributes with JSValueInWrappedObject
https://bugs.webkit.org/show_bug.cgi?id=189466
Summary Add bindings support for representing attributes with JSValueInWrappedObject
Andy Estes
Reported 2018-09-09 19:37:43 PDT
In CustomEvent, History, MessageEvent, PaymentMethodChangeEvent, and PaymentResponse, we have custom bindings support for representing attributes of type object or any. These custom bindings tend to do two things: 1. Add a custom getter for an attribute of type object or any that converts the native value to a JSValue, cache that JSValue in a JSValueInWrappedObject in the wrapper class, then return the cached JSValue. 2. Add a custom mark function that visits the cached JSValueInWrappedObject as well as any other JSValueInWrappedObjects in the wrapper class. We should teach the bindings generator to do this for us for attributes of object or any type (perhaps with a custom annotation).
Attachments
Andy Estes
Comment 1 2018-09-09 19:41:24 PDT
(In reply to Andy Estes from comment #0) > In CustomEvent, History, MessageEvent, PaymentMethodChangeEvent, and > PaymentResponse, we have custom bindings support for representing attributes > of type object or any. > > These custom bindings tend to do two things: > > 1. Add a custom getter for an attribute of type object or any that converts > the native value to a JSValue, cache that JSValue in a > JSValueInWrappedObject in the wrapper class, then return the cached JSValue. > 2. Add a custom mark function that visits the cached JSValueInWrappedObject > as well as any other JSValueInWrappedObjects in the wrapper class. > > We should teach the bindings generator to do this for us for attributes of > object or any type (perhaps with a custom annotation). s/wrapper class/wrapped class
Note You need to log in before you can comment on or make changes to this bug.