Bug 189465 – XMLHttpRequest: overrideMimeType should not update the response's "Content-Type" header

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Rob Buis]

From the spec:
Acts as if the `Content-Type` header value for response is mime. (It does not actually change the header though.)
https://xhr.spec.whatwg.org/#dom-xmlhttprequest-overridemimetype

[Rob Buis]

Created attachment 349289 [details]
Patch

[Rob Buis]

Created attachment 349291 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 349291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349291&action=review

> Source/WebCore/ChangeLog:9
> +        response's "Content-Type" header anymore.

Are you able to provide a link to a spec change (github issue or something) showing that change?

> Source/WebCore/xml/XMLHttpRequest.cpp:-969
> -        m_response.setHTTPHeaderField(HTTPHeaderName::ContentType, m_mimeTypeOverride);

Can you please also remove the FIXME comment from XMLHttpRequest::didReceiveData? (I guess setting the m_responseEncoding from m_mimeTypeOverride is still valid, right?).

[Rob Buis]

Created attachment 349296 [details]
Patch

[Frédéric Wang (:fredw)]

For reference,

"Acts as if the `Content-Type` header value for response is mime. (It does not actually change the header though.)"

was added in

https://github.com/whatwg/xhr/commit/121cee50b6f51215f046266642964b4c53a02a7c

[WebKit Commit Bot]

Comment on attachment 349296 [details]
Patch

Rejecting attachment 349296 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 349296, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9158067

[Rob Buis]

Created attachment 349299 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 349299 [details]
Patch

Clearing flags on attachment: 349299

Committed r235844: <https://trac.webkit.org/changeset/235844>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44295412>