Bug 189454 - REGRESSION (r235153): [iOS] Can't move selection start grabber when selecting text in a subframe
Summary: REGRESSION (r235153): [iOS] Can't move selection start grabber when selecting...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-08 15:58 PDT by Wenson Hsieh
Modified: 2018-09-08 21:08 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.24 KB, patch)
2018-09-08 18:04 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-09-08 15:58:57 PDT 
After r235153, I can't move the selection start grabber when selecting text in a subframe on iOS, if the subframe isn't at the very top of the main document. To reproduce:

1. Visit https://whsieh.github.io/examples/subframes
2. Scroll to the very bottom, where "lorem-tiny.html" is embedded in a subframe
3. Long press to select some text
4. Try to move the grabber at the start of the selection.

Expected: able to change the selection by moving the grabber.
Observed: the selection start grabber snaps to the character before the selection end grabber, and cannot be moved.
Comment 1 Radar WebKit Bug Importer 2018-09-08 16:03:00 PDT 
<rdar://problem/44265956>
Comment 2 Wenson Hsieh 2018-09-08 18:04:51 PDT 
Created attachment 349268 [details]
Patch
Comment 3 WebKit Commit Bot 2018-09-08 20:25:12 PDT 
Comment on attachment 349268 [details]
Patch

Clearing flags on attachment: 349268

Committed r235834: <https://trac.webkit.org/changeset/235834>
Comment 4 WebKit Commit Bot 2018-09-08 20:25:14 PDT 
All reviewed patches have been landed.  Closing bug.