Bug 189452 - Clean up code related to Document node removal
Summary: Clean up code related to Document node removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-08 12:34 PDT by Simon Fraser (smfr)
Modified: 2018-09-08 13:21 PDT (History)
12 users (show)

See Also:

Attachments
Patch (9.12 KB, patch)
2018-09-08 12:35 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-09-08 12:34:13 PDT 
Clean up code related to Document node removal
Comment 1 Simon Fraser (smfr) 2018-09-08 12:35:56 PDT 
Created attachment 349258 [details]
Patch
Comment 2 Wenson Hsieh 2018-09-08 13:15:25 PDT 
Comment on attachment 349258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349258&action=review

> Source/WebCore/dom/Document.h:760
> +    enum class NodeRemoval { Node, ChildrenOfNode };

Do we care about shrinking the width of enums that are only passed around as arguments, and not stored anywhere? (If so, this should be 8 bits)
Comment 3 Simon Fraser (smfr) 2018-09-08 13:20:07 PDT 
https://trac.webkit.org/r235830
Comment 4 Radar WebKit Bug Importer 2018-09-08 13:21:25 PDT 
<rdar://problem/44263412>