Correctly interpret from angle for conic gradients

[Megan Gardner]

Correctly interperate from angle for conic gradients

[Megan Gardner]

Created attachment 349221 [details]
Patch

[Megan Gardner]

<rdar://problem/44158271>

[Tim Horton]

interperate is not a word

[Megan Gardner]

Created attachment 349224 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 349224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349224&action=review

> Source/WebCore/css/CSSGradientValue.cpp:1439
> -        angle = m_angle->floatValue(CSSPrimitiveValue::CSS_DEG);
> +        angle = m_angle->floatValue(CSSPrimitiveValue::CSS_RAD);

How do you know this is radians? It looks like consumeAngle() can use whatever units the source specified.

[Megan Gardner]

Because this is what is fed to CG, and CG wants radians. It's the only thing it's used for.

[WebKit Commit Bot]

Comment on attachment 349224 [details]
Patch

Clearing flags on attachment: 349224

Committed r235868: <https://trac.webkit.org/changeset/235868>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

(In reply to Megan Gardner from comment #6)
> Because this is what is fed to CG, and CG wants radians. It's the only thing
> it's used for.

But this is cross-platform code. I think ConicData needs to rename 'angle' to 'angleRadians' or at least have a comments saying that it's Radians. Ideally, we'd have a typedef.

[Megan Gardner]

Follow up fix for Simon's naming request
https://trac.webkit.org/changeset/235877/webkit