Bug 189438 – [MediaCapabilities] Implement MediaEngineConfigurationFactory registration

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[MediaCapabilities] Implement MediaEngineConfigurationFactory registration

[Jer Noble]

Created attachment 349214 [details]
Patch

[EWS Watchlist]

Comment on attachment 349214 [details]
Patch

Attachment 349214 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9134647

New failing tests:
media/mediacapabilities/mediacapabilities-types.html

[EWS Watchlist]

Created attachment 349219 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349214 [details]
Patch

Attachment 349214 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9134779

New failing tests:
media/mediacapabilities/mediacapabilities-types.html

[EWS Watchlist]

Comment on attachment 349214 [details]
Patch

Attachment 349214 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9134807

New failing tests:
media/mediacapabilities/mediacapabilities-types.html

[EWS Watchlist]

Created attachment 349220 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349214 [details]
Patch

Attachment 349214 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9134844

New failing tests:
media/mediacapabilities/mediacapabilities-types.html

[EWS Watchlist]

Created attachment 349225 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 349214 [details]
Patch

Attachment 349214 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9135813

New failing tests:
media/mediacapabilities/mediacapabilities-types.html

[EWS Watchlist]

Created attachment 349230 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349214 [details]
Patch

Attachment 349214 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9136019

New failing tests:
media/mediacapabilities/mediacapabilities-types.html

[EWS Watchlist]

Created attachment 349235 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Jer Noble]

Created attachment 349315 [details]
Patch

[Jer Noble]

Created attachment 349317 [details]
Patch

[Eric Carlson]

Comment on attachment 349317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349317&action=review

> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:39
> +typedef struct __CVBuffer *CVPixelBufferRef;
> +typedef struct __IOSurface *IOSurfaceRef;
> +

Is this supposed to be part of this patch?

[Jer Noble]

(In reply to Eric Carlson from comment #15)
> Comment on attachment 349317 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349317&action=review
> 
> > Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:39
> > +typedef struct __CVBuffer *CVPixelBufferRef;
> > +typedef struct __IOSurface *IOSurfaceRef;
> > +
> 
> Is this supposed to be part of this patch?

Yes. Changing the order of files in SourcesCocoa.txt exposed a pre-existing issue where those types were not directly defined in DisplayCaptureSourceCocoa.h.

[WebKit Commit Bot]

Comment on attachment 349317 [details]
Patch

Clearing flags on attachment: 349317

Committed r235919: <https://trac.webkit.org/changeset/235919>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44361779>