Bug 189434 - contentfiltering tests leak documents
Summary: contentfiltering tests leak documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-07 14:49 PDT by Simon Fraser (smfr)
Modified: 2019-02-21 20:32 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.16 KB, patch)
2019-02-21 13:11 PST, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-09-07 14:49:29 PDT
All these tests leak documents:

contentfiltering/block-after-add-data-then-deny-unblock.html [ Leak ]
contentfiltering/block-after-add-data.html [ Leak ]
contentfiltering/block-after-finished-adding-data-then-deny-unblock.html [ Leak ]
contentfiltering/block-after-finished-adding-data.html [ Leak ]
contentfiltering/block-after-response-then-deny-unblock.html [ Leak ]
contentfiltering/block-after-response.html [ Leak ]
contentfiltering/block-after-will-send-request-then-deny-unblock.html [ Leak ]
contentfiltering/block-after-will-send-request.html [ Leak ]
Comment 1 Radar WebKit Bug Importer 2018-09-07 14:49:55 PDT
<rdar://problem/44239943>
Comment 2 Andy Estes 2019-02-21 13:11:03 PST
Created attachment 362634 [details]
Patch
Comment 3 WebKit Commit Bot 2019-02-21 14:51:59 PST Comment hidden (obsolete)
Comment 4 Andy Estes 2019-02-21 15:12:11 PST Comment hidden (obsolete)
Comment 5 Andy Estes 2019-02-21 20:32:52 PST
This was actually landed by the commit queue in r241906: <https://trac.webkit.org/changeset/241906>

The error message in comment #3 actually wasn't a rejection.