RESOLVED FIXED 189433
Touch Bar displays an active PIP button for audio elements (and it doesn't do anything) 
https://bugs.webkit.org/show_bug.cgi?id=189433
Summary Touch Bar displays an active PIP button for audio elements (and it doesn't do...
Matt Rajca
Reported 2018-09-07 14:41:17 PDT
When playing an audio element, the media Touch Bar displays an active PIP button even though only videos are PIP-able. Pressing it does not do anything. It seems like canTogglePictureInPicture is set to YES unconditionally on the WebPlaybackControlsManager. It should be set based on the media type.
Attachments
Patch (32.46 KB, patch)
2018-09-07 14:59 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (32.43 KB, patch)
2018-09-07 15:25 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (33.61 KB, patch)
2018-09-07 15:40 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (33.69 KB, patch)
2018-09-07 16:40 PDT, Matt Rajca 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Matt Rajca
Comment 1 2018-09-07 14:41:50 PDT
<rdar://problem/44186498>
Matt Rajca
Comment 2 2018-09-07 14:59:26 PDT
Created attachment 349199 [details] Patch
Matt Rajca
Comment 3 2018-09-07 15:25:22 PDT
Created attachment 349206 [details] Patch
Matt Rajca
Comment 4 2018-09-07 15:40:01 PDT
Created attachment 349209 [details] Patch
Matt Rajca
Comment 5 2018-09-07 16:40:41 PDT
Created attachment 349216 [details] Patch
Eric Carlson
Comment 6 2018-09-07 17:46:48 PDT
Comment on attachment 349216 [details] Patch Very nice, thank you!
Matt Rajca
Comment 7 2018-09-10 10:20:35 PDT
Committed r235850: <https://trac.webkit.org/changeset/235850>
Note You need to log in before you can comment on or make changes to this bug.