Bug 189433 - Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)
Summary: Touch Bar displays an active PIP button for audio elements (and it doesn't do...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Rajca
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-07 14:41 PDT by Matt Rajca
Modified: 2018-09-10 10:20 PDT (History)
1 user (show)

See Also:

Attachments
Patch (32.46 KB, patch)
2018-09-07 14:59 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (32.43 KB, patch)
2018-09-07 15:25 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (33.61 KB, patch)
2018-09-07 15:40 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (33.69 KB, patch)
2018-09-07 16:40 PDT, Matt Rajca 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2018-09-07 14:41:17 PDT 
When playing an audio element, the media Touch Bar displays an active PIP button even though only videos are PIP-able. Pressing it does not do anything. It seems like canTogglePictureInPicture is set to YES unconditionally on the WebPlaybackControlsManager. It should be set based on the media type.
Comment 1 Matt Rajca 2018-09-07 14:41:50 PDT 
<rdar://problem/44186498>
Comment 2 Matt Rajca 2018-09-07 14:59:26 PDT 
Created attachment 349199 [details]
Patch
Comment 3 Matt Rajca 2018-09-07 15:25:22 PDT 
Created attachment 349206 [details]
Patch
Comment 4 Matt Rajca 2018-09-07 15:40:01 PDT 
Created attachment 349209 [details]
Patch
Comment 5 Matt Rajca 2018-09-07 16:40:41 PDT 
Created attachment 349216 [details]
Patch
Comment 6 Eric Carlson 2018-09-07 17:46:48 PDT 
Comment on attachment 349216 [details]
Patch

Very nice, thank you!
Comment 7 Matt Rajca 2018-09-10 10:20:35 PDT 
Committed r235850: <https://trac.webkit.org/changeset/235850>