Bug 189427 – RealtimeOutgoingVideoSourceCocoa should use VTImageRotationSession to rotate CVPixelBuffers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

RealtimeOutgoingVideoSourceCocoa should use VTImageRotationSession to rotate CVPixelBuffers

[youenn fablet]

Created attachment 349177 [details]
Patch

[youenn fablet]

Comment on attachment 349177 [details]
Patch

Code following more or less ImageDecoderAVFObjC::storeSampleBuffer.
Maybe I should check return error for VTImageRotationSessionCreate, VTImageRotationSessionSetProperty, CVPixelBufferPoolCreate and CVPixelBufferPoolCreatePixelBuffer?

[Eric Carlson]

Comment on attachment 349177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349177&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:76
> +        VTImageRotationSessionCreate(kCFAllocatorDefault, rotation, &rawRotationSession);
> +        VTImageRotationSessionSetProperty(rawRotationSession, kVTImageRotationPropertyKey_EnableHighSpeedTransfer, kCFBooleanTrue);

Nit: these can both fail, you should check the return code and bail on failure so we don't crash later.

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:93
> +        CVPixelBufferPoolCreate(kCFAllocatorDefault, nullptr, (__bridge CFDictionaryRef)pixelAttributes, &pool);

Ditto.

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:102
> +    CVPixelBufferPoolCreatePixelBuffer(kCFAllocatorDefault, m_rotationPool.get(), &rawRotatedBuffer);

Ditto.

[youenn fablet]

Created attachment 349197 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 349197 [details]
Patch for landing

Clearing flags on attachment: 349197

Committed r235810: <https://trac.webkit.org/changeset/235810>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44241898>