Bug 189425 - CBOR coders should only be compiled if WebAuthN is enabled
Summary: CBOR coders should only be compiled if WebAuthN is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-07 11:58 PDT by Don Olmstead
Modified: 2018-09-10 14:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.61 KB, patch)
2018-09-07 12:01 PDT, Don Olmstead
jiewen_tan: review+
Details | Formatted Diff | Diff
Patch (7.12 KB, patch)
2018-09-10 12:05 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-09-07 11:58:25 PDT
Everything else in Modules/webauthn has ENABLE(WEB_AUTHN) guards
Comment 1 Don Olmstead 2018-09-07 12:01:37 PDT
Created attachment 349172 [details]
Patch
Comment 2 Jiewen Tan 2018-09-07 12:09:01 PDT
Comment on attachment 349172 [details]
Patch

Looks good to me.
Comment 3 Don Olmstead 2018-09-10 12:05:54 PDT
Created attachment 349321 [details]
Patch

Add guards around associated tests.
Comment 4 Jiewen Tan 2018-09-10 13:20:33 PDT
Comment on attachment 349321 [details]
Patch

Good catch. r=me.
Comment 5 WebKit Commit Bot 2018-09-10 14:11:31 PDT
Comment on attachment 349321 [details]
Patch

Clearing flags on attachment: 349321

Committed r235861: <https://trac.webkit.org/changeset/235861>
Comment 6 WebKit Commit Bot 2018-09-10 14:11:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-10 14:12:45 PDT
<rdar://problem/44316884>