RESOLVED FIXED 189413
Tests checking document GC in case of ActiveDOMObjects are flaky 
https://bugs.webkit.org/show_bug.cgi?id=189413
Summary Tests checking document GC in case of ActiveDOMObjects are flaky
youenn fablet
Reported 2018-09-07 10:13:31 PDT
Tests checking document GC in case of ActiveDOMObjects are flaky
Attachments
Patch (6.89 KB, patch)
2018-09-07 10:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2018-09-21 17:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 2 2018-09-07 10:30:15 PDT
Created attachment 349155 [details] Patch
WebKit Commit Bot
Comment 3 2018-09-07 16:13:39 PDT
Comment on attachment 349155 [details] Patch Clearing flags on attachment: 349155 Committed r235819: <https://trac.webkit.org/changeset/235819>
WebKit Commit Bot
Comment 4 2018-09-07 16:13:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-07 16:14:22 PDT
<rdar://problem/44243231>
Ryan Haddad
Comment 6 2018-09-10 09:36:27 PDT
http/tests/media/clearkey/collect-webkit-media-session.html failed here, and appears to remain quite flaky: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r235847%20(7874)/results.html http/tests/IndexedDB/collect-IDB-objects.https.html failed here: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r235833%20(6651)/results.html
Ryan Haddad
Comment 7 2018-09-13 17:47:40 PDT
Reopening because these tests are still flaky.
Simon Fraser (smfr)
Comment 8 2018-09-21 11:42:08 PDT
This means we have no effective leak tracking :(
Ryan Haddad
Comment 9 2018-09-21 11:51:14 PDT
Marked http/tests/media/clearkey/collect-webkit-media-session.html as flaky in https://trac.webkit.org/r236340 because it is frequently popping up on the bots. Youenn, would you take a look at this.
youenn fablet
Comment 10 2018-09-21 15:02:10 PDT
(In reply to Ryan Haddad from comment #9) > Marked http/tests/media/clearkey/collect-webkit-media-session.html as flaky > in https://trac.webkit.org/r236340 because it is frequently popping up on > the bots. > > Youenn, would you take a look at this. Looked at it a bit. Apparently, the document is not always GCed, but it has no pending activity so something else is going on. I'll try digging further with the GC heap debugger.
youenn fablet
Comment 11 2018-09-21 17:39:26 PDT
Created attachment 350464 [details] Patch
WebKit Commit Bot
Comment 12 2018-09-22 16:43:00 PDT
Comment on attachment 350464 [details] Patch Clearing flags on attachment: 350464 Committed r236389: <https://trac.webkit.org/changeset/236389>
WebKit Commit Bot
Comment 13 2018-09-22 16:43:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.