Bug 189401 - [WebAssembly] Optimize JS to Wasm call by using pointer of Signature as SignatureIndex
Summary: [WebAssembly] Optimize JS to Wasm call by using pointer of Signature as Signa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-07 02:42 PDT by Yusuke Suzuki
Modified: 2018-09-13 14:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.89 KB, patch)
2018-09-07 02:52 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (24.14 KB, patch)
2018-09-07 03:11 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (30.48 KB, patch)
2018-09-07 05:17 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (35.43 KB, patch)
2018-09-07 05:29 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (35.46 KB, patch)
2018-09-07 05:34 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (35.46 KB, patch)
2018-09-07 05:35 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (36.80 KB, patch)
2018-09-07 05:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (36.83 KB, patch)
2018-09-07 06:41 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-09-07 02:42:45 PDT 
[WebAssembly] Optimize JS to Wasm call by using pointer of Signature as SignatureIndex
Comment 1 Yusuke Suzuki 2018-09-07 02:52:02 PDT 
Created attachment 349131 [details]
Patch
Comment 2 Yusuke Suzuki 2018-09-07 03:11:30 PDT 
Created attachment 349134 [details]
Patch
Comment 3 Yusuke Suzuki 2018-09-07 05:17:05 PDT 
Created attachment 349136 [details]
Patch
Comment 4 Yusuke Suzuki 2018-09-07 05:29:40 PDT 
Created attachment 349137 [details]
Patch
Comment 5 Yusuke Suzuki 2018-09-07 05:34:42 PDT 
Created attachment 349138 [details]
Patch
Comment 6 Yusuke Suzuki 2018-09-07 05:35:27 PDT 
Created attachment 349139 [details]
Patch
Comment 7 Yusuke Suzuki 2018-09-07 05:53:28 PDT 
Created attachment 349140 [details]
Patch
Comment 8 Yusuke Suzuki 2018-09-07 06:41:29 PDT 
Created attachment 349143 [details]
Patch
Comment 9 Mark Lam 2018-09-07 10:19:31 PDT 
Comment on attachment 349143 [details]
Patch

r=me.  I think you should remove Signature::firstValidIndex since it is no longer used.
Comment 10 Yusuke Suzuki 2018-09-07 10:23:01 PDT 
(In reply to Mark Lam from comment #9)
> Comment on attachment 349143 [details]
> Patch
> 
> r=me.  I think you should remove Signature::firstValidIndex since it is no
> longer used.

Right! Thanks. Fixed.
Comment 11 Yusuke Suzuki 2018-09-07 10:29:09 PDT 
Committed r235786: <https://trac.webkit.org/changeset/235786>
Comment 12 Radar WebKit Bug Importer 2018-09-07 10:30:44 PDT 
<rdar://problem/44228602>
Comment 13 Saam Barati 2018-09-13 14:12:47 PDT 
Comment on attachment 349143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349143&action=review

Nice change.

The only thing that's weird to me is that we're still calling it an index. We should revise the name since the old name indicated an implementation style. But we're no longer using it as an index. Maybe we could call it something like UniqueSignature.

> Source/JavaScriptCore/ChangeLog:20
> +        This change significantly optimizes JS to wasm calls (1e7 times) from 600ms to 320ms.

Our wasm entry is so slow :(