Unify most of the WebKit C API sources
Created attachment 349121 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Created attachment 349122 [details] Patch
Created attachment 349123 [details] Patch
Comment on attachment 349123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349123&action=review Windows failure looks unrelated. > Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:243 > + writeToFile(WebKit::NetworkCache::Data(sourceJSON.characters8(), serializedLength)); Would just an initializer list work here?
(In reply to Alex Christensen from comment #5) > Comment on attachment 349123 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349123&action=review > > Windows failure looks unrelated. I thought so too. > Would just an initializer list work here? Probably!
Comment on attachment 349123 [details] Patch Clearing flags on attachment: 349123 Committed r235823: <https://trac.webkit.org/changeset/235823>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44246069>
Follow-up build fix in https://trac.webkit.org/changeset/235826/webkit
Filed for MSVC issue: Bug 189467 – [MSVC] X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions