WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189396
Add a standalone version of the test runtime tree map viewer, that can accept stats.json from a local test run
https://bugs.webkit.org/show_bug.cgi?id=189396
Summary
Add a standalone version of the test runtime tree map viewer, that can accept...
Simon Fraser (smfr)
Reported
2018-09-06 21:18:24 PDT
Add a standalone version of the test runtime tree map viewer, that can accept stats.json from a local test run
Attachments
Patch
(19.70 KB, patch)
2018-09-06 21:20 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(47.85 KB, patch)
2018-09-07 19:01 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(26.13 KB, patch)
2020-09-03 14:15 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2018-09-06 21:20:02 PDT
Created
attachment 349111
[details]
Patch
Simon Fraser (smfr)
Comment 2
2018-09-06 21:20:54 PDT
This should probably live in some other directory. Maybe it should be bundled in layout_test_results and linked from results.html.
Alexey Proskuryakov
Comment 3
2018-09-07 09:16:55 PDT
Comment on
attachment 349111
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=349111&action=review
> Tools/ChangeLog:12 > + This should probably live in some other directory. Maybe it should be bundled in layout_test_results > + and linked from results.html.
How about somewhere on build.webkit.org, and having a link to it from "Tests and Performance" section of the landing page?
Simon Fraser (smfr)
Comment 4
2018-09-07 11:12:37 PDT
I want someone to be able to see the tree map for their local results, so the page would have to be able to load a local stats.json (and probably the results.json in future). A single click from results.html would be ideal, rather than forcing someone to drag and drop the json file.
Alexey Proskuryakov
Comment 5
2018-09-07 14:02:39 PDT
It that something that you want to figure out before the patch lands? Not sure if it’s meant for review if so. Given its current behavior though, I think that changes in
comment 3
may be appropriate before landing.
Simon Fraser (smfr)
Comment 6
2018-09-07 19:01:52 PDT
Created
attachment 349227
[details]
Patch
Simon Fraser (smfr)
Comment 7
2020-09-03 09:46:19 PDT
Bump.
Simon Fraser (smfr)
Comment 8
2020-09-03 09:56:22 PDT
I think we should put this file into fast/harness and include it in layout-test-results, with a link from results.html.
Simon Fraser (smfr)
Comment 9
2020-09-03 14:15:01 PDT
Created
attachment 407909
[details]
Patch
EWS
Comment 10
2020-09-08 09:46:28 PDT
Committed
r266727
: <
https://trac.webkit.org/changeset/266727
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 407909
[details]
.
Radar WebKit Bug Importer
Comment 11
2020-09-08 09:47:29 PDT
<
rdar://problem/68513459
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug