On a second glance, a couple of things are wonky here: - This file isn't in the unified sources list (!). It's currently building via the Xcode project only. - Since this file is not just for Cocoa platforms, the #imports should be replaced by #includes.
Created attachment 349109 [details] Patch
Comment on attachment 349109 [details] Patch Rejecting attachment 349109 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 349109, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=349109&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189394&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 349109 from bug 189394. Fetching: https://bugs.webkit.org/attachment.cgi?id=349109 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Sources.txt patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj Hunk #1 succeeded at 4824 (offset 1 line). Hunk #2 FAILED at 28781. Hunk #3 FAILED at 29788. Hunk #4 succeeded at 31494 (offset 5 lines). 2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/editing/FontAttributeChanges.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9133546
Created attachment 349208 [details] Patch for landing
Comment on attachment 349208 [details] Patch for landing Clearing flags on attachment: 349208 Committed r235814: <https://trac.webkit.org/changeset/235814>