Add support for unified plan transceivers
Created attachment 349115 [details] Patch
Attachment 349115 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 349115 [details] Patch Attachment 349115 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9123804 New failing tests: fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html fast/mediastream/RTCPeerConnection-inspect-offer.html fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html fast/mediastream/RTCPeerConnection-inspect-answer.html fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html fast/mediastream/RTCPeerConnection-addIceCandidate.html fast/mediastream/RTCPeerConnection-onnegotiationneeded.html
Created attachment 349120 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 349115 [details] Patch Attachment 349115 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9125034 New failing tests: fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html fast/mediastream/RTCPeerConnection-inspect-offer.html fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html fast/mediastream/RTCPeerConnection-inspect-answer.html fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html fast/mediastream/RTCPeerConnection-addIceCandidate.html fast/mediastream/RTCPeerConnection-onnegotiationneeded.html
Created attachment 349132 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 349149 [details] Patch
Attachment 349149 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 349152 [details] Patch
Attachment 349152 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 349154 [details] Patch
Attachment 349154 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 349154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349154&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:156 > if (kind != "audio" && kind != "video") Nit: might as well fix these while you are here: "audio"_s && "video"_s > LayoutTests/ChangeLog:45 > +2018-09-06 Daniel Bates <dabates@apple.com> > + > + [iOS] Add a test to ensure that DOM keyup events have the correct details > + https://bugs.webkit.org/show_bug.cgi?id=189327 > + > + Reviewed by Wenson Hsieh. > + > + Until we fix <rdar://problem/35282761> DOM keyup events will have incorrect details on iOS > + when dispatched in response to a hardware keyboard press. For now, land expected failure results. > + > + * fast/events/ios/keyup-expected.txt: Added. > + * fast/events/ios/keyup.html: Added. > + * resources/ui-helper.js: > + (window.UIHelper.typeCharacter): Escape backslash characters in order to build up > + a well-formed UI script to evaluate. > + Oops
Created attachment 349188 [details] Patch for landing
Attachment 349188 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 349188 [details] Patch for landing Clearing flags on attachment: 349188 Committed r235809: <https://trac.webkit.org/changeset/235809>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44240321>