Bug 18938 - [GTK] Plugins not resized
Summary: [GTK] Plugins not resized
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: marcoil
Depends on:
Reported: 2008-05-08 02:50 PDT by Marco Barisione
Modified: 2009-05-25 08:57 PDT (History)
5 users (show)

See Also:

Fixes the issue for r33931 (1.14 KB, patch)
2008-05-20 07:23 PDT, marcoil
no flags Details | Formatted Diff | Diff
Fix for r34689 (1.19 KB, patch)
2008-06-20 09:48 PDT, marcoil
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Barisione 2008-05-08 02:50:15 PDT
Plugin visited directly (e.g. inserting http://youtube.com/active_sharing.swf in the URL bar) are not resized when the window is resized.
Comment 1 marcoil 2008-05-20 07:23:50 PDT
Created attachment 21255 [details]
Fixes the issue for r33931

This patch ensures that changes in the geometry are sent to the plugin when the PluginView is the whole document (NP_FULL).
Comment 2 marcoil 2008-05-20 07:59:25 PDT
I forgot to mention that for the fix to work, the patches for Gtk present in bug #18935 have to be applied.
Comment 3 Alp Toker 2008-06-01 08:55:56 PDT
The issue does exist and the patch fixes GTK, but Anders remarked that this fix is wrong.

Anders, could you elaborate?
Comment 4 Eric Seidel (no email) 2008-06-06 13:44:21 PDT
Hum... Adam Roben or someone who hacks on windows should take a look at this.
Comment 5 marcoil 2008-06-20 09:48:11 PDT
Created attachment 21856 [details]
Fix for r34689

I've made a new patch that should fix the issue without affecting the Windows port.
I've used XP_UNIX because the X11 Qt port has the same behavior.
Comment 6 Simon Hausmann 2008-07-26 06:23:18 PDT
Comment on attachment 21856 [details]
Fix for r34689

Looks good to me. I would've thought that set should _always_ call setNPWindowRect, even in a windowed resize, but it seems that is not necessary. This patch is safe in any case I would say.
Comment 7 Mark Rowe (bdash) 2008-07-26 22:49:30 PDT
Landed in r35393.