Bug 189377 - [LFC][BFC] Add support for min(max)-height
Summary: [LFC][BFC] Add support for min(max)-height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-06 15:13 PDT by zalan
Modified: 2018-09-07 09:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (33.50 KB, patch)
2018-09-06 15:16 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-09-06 15:13:07 PDT 
ssia
Comment 1 zalan 2018-09-06 15:16:32 PDT 
Created attachment 349082 [details]
Patch
Comment 2 zalan 2018-09-06 15:40:02 PDT 
Committed r235763: <https://trac.webkit.org/changeset/235763>
Comment 3 Truitt Savell 2018-09-07 08:40:27 PDT 
Looks like fast/block/block-only/absolute-position-min-max-height.html is a constant failure on iOS

Test History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fblock%2Fblock-only%2Fabsolute-position-min-max-height.html

Diff:
--- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/fast/block/block-only/absolute-position-min-max-height-expected.txt
+++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/fast/block/block-only/absolute-position-min-max-height-actual.txt
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x602
-  RenderView at (0,0) size 785x600
-layer at (0,0) size 785x8
-  RenderBlock {HTML} at (0,0) size 785x8
-    RenderBody {BODY} at (8,8) size 769x0
+layer at (0,0) size 800x602
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x8
+  RenderBlock {HTML} at (0,0) size 800x8
+    RenderBody {BODY} at (8,8) size 784x0
 layer at (8,8) size 102x54
   RenderBlock (positioned) {DIV} at (8,8) size 102x54 [border: (1px solid #008000)]
     RenderBlock {DIV} at (1,1) size 102x52 [border: (1px solid #FF0000)]
Comment 4 Radar WebKit Bug Importer 2018-09-07 08:40:44 PDT 
<rdar://problem/44225408>
Comment 5 zalan 2018-09-07 09:29:29 PDT 
(In reply to Truitt Savell from comment #3)
> Looks like fast/block/block-only/absolute-position-min-max-height.html is a
> constant failure on iOS
> 
> Test History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Fblock%2Fblock-only%2Fabsolute-position-
> min-max-height.html
> 
> Diff:
> ---
> /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-
> results/fast/block/block-only/absolute-position-min-max-height-expected.txt
> +++
> /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-
> results/fast/block/block-only/absolute-position-min-max-height-actual.txt
> @@ -1,8 +1,8 @@
> -layer at (0,0) size 785x602
> -  RenderView at (0,0) size 785x600
> -layer at (0,0) size 785x8
> -  RenderBlock {HTML} at (0,0) size 785x8
> -    RenderBody {BODY} at (8,8) size 769x0
> +layer at (0,0) size 800x602
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x8
> +  RenderBlock {HTML} at (0,0) size 800x8
> +    RenderBody {BODY} at (8,8) size 784x0
>  layer at (8,8) size 102x54
>    RenderBlock (positioned) {DIV} at (8,8) size 102x54 [border: (1px solid
> #008000)]
>      RenderBlock {DIV} at (1,1) size 102x52 [border: (1px solid #FF0000)]

https://trac.webkit.org/changeset/235783/webkit should take care of it.