RESOLVED FIXED 189377
[LFC][BFC] Add support for min(max)-height 
https://bugs.webkit.org/show_bug.cgi?id=189377
Summary [LFC][BFC] Add support for min(max)-height
zalan
Reported 2018-09-06 15:13:07 PDT
ssia
Attachments
Patch (33.50 KB, patch)
2018-09-06 15:16 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-09-06 15:16:32 PDT
Created attachment 349082 [details] Patch
zalan
Comment 2 2018-09-06 15:40:02 PDT
Committed r235763: <https://trac.webkit.org/changeset/235763>
Truitt Savell
Comment 3 2018-09-07 08:40:27 PDT
Looks like fast/block/block-only/absolute-position-min-max-height.html is a constant failure on iOS Test History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fblock%2Fblock-only%2Fabsolute-position-min-max-height.html Diff: --- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/fast/block/block-only/absolute-position-min-max-height-expected.txt +++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/fast/block/block-only/absolute-position-min-max-height-actual.txt @@ -1,8 +1,8 @@ -layer at (0,0) size 785x602 - RenderView at (0,0) size 785x600 -layer at (0,0) size 785x8 - RenderBlock {HTML} at (0,0) size 785x8 - RenderBody {BODY} at (8,8) size 769x0 +layer at (0,0) size 800x602 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x8 + RenderBlock {HTML} at (0,0) size 800x8 + RenderBody {BODY} at (8,8) size 784x0 layer at (8,8) size 102x54 RenderBlock (positioned) {DIV} at (8,8) size 102x54 [border: (1px solid #008000)] RenderBlock {DIV} at (1,1) size 102x52 [border: (1px solid #FF0000)]
Radar WebKit Bug Importer
Comment 4 2018-09-07 08:40:44 PDT
<rdar://problem/44225408>
zalan
Comment 5 2018-09-07 09:29:29 PDT
(In reply to Truitt Savell from comment #3) > Looks like fast/block/block-only/absolute-position-min-max-height.html is a > constant failure on iOS > > Test History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fblock%2Fblock-only%2Fabsolute-position- > min-max-height.html > > Diff: > --- > /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test- > results/fast/block/block-only/absolute-position-min-max-height-expected.txt > +++ > /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test- > results/fast/block/block-only/absolute-position-min-max-height-actual.txt > @@ -1,8 +1,8 @@ > -layer at (0,0) size 785x602 > - RenderView at (0,0) size 785x600 > -layer at (0,0) size 785x8 > - RenderBlock {HTML} at (0,0) size 785x8 > - RenderBody {BODY} at (8,8) size 769x0 > +layer at (0,0) size 800x602 > + RenderView at (0,0) size 800x600 > +layer at (0,0) size 800x8 > + RenderBlock {HTML} at (0,0) size 800x8 > + RenderBody {BODY} at (8,8) size 784x0 > layer at (8,8) size 102x54 > RenderBlock (positioned) {DIV} at (8,8) size 102x54 [border: (1px solid > #008000)] > RenderBlock {DIV} at (1,1) size 102x52 [border: (1px solid #FF0000)] https://trac.webkit.org/changeset/235783/webkit should take care of it.
Note You need to log in before you can comment on or make changes to this bug.