Bug 189364 - Actively prewarm processes created for prewarm pool
Summary: Actively prewarm processes created for prewarm pool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-06 12:33 PDT by Antti Koivisto
Modified: 2018-09-06 14:38 PDT (History)
6 users (show)

See Also:

Attachments
patch (20.79 KB, patch)
2018-09-06 12:56 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (20.79 KB, patch)
2018-09-06 13:14 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (20.74 KB, patch)
2018-09-06 13:15 PDT, Antti Koivisto 		cdumez: review+
Details | Formatted Diff | Diff
patch (20.84 KB, patch)
2018-09-06 13:47 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (20.99 KB, patch)
2018-09-06 14:08 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-09-06 12:33:56 PDT 
Prewarming can speed up first page load in a process.
Comment 1 Antti Koivisto 2018-09-06 12:56:54 PDT 
Created attachment 349055 [details]
patch
Comment 2 EWS Watchlist 2018-09-06 13:00:32 PDT 
Attachment 349055 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ProcessWarming.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/page/ProcessWarming.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2018-09-06 13:14:24 PDT 
Created attachment 349058 [details]
patch
Comment 4 Antti Koivisto 2018-09-06 13:15:38 PDT 
Created attachment 349059 [details]
patch
Comment 5 Chris Dumez 2018-09-06 13:40:16 PDT 
Comment on attachment 349059 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349059&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:608
> +    WebCore::ProcessWarming::prewarm();

We likely do not need the WebCore::

> Source/WebKit/WebProcess/WebProcess.h:133
> +    void prewarm();

Does this really need to be public ?
Comment 6 Antti Koivisto 2018-09-06 13:47:16 PDT 
Created attachment 349066 [details]
patch
Comment 7 Antti Koivisto 2018-09-06 14:08:22 PDT 
Created attachment 349069 [details]
patch
Comment 8 WebKit Commit Bot 2018-09-06 14:37:23 PDT 
Comment on attachment 349069 [details]
patch

Clearing flags on attachment: 349069

Committed r235758: <https://trac.webkit.org/changeset/235758>
Comment 9 WebKit Commit Bot 2018-09-06 14:37:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-09-06 14:38:23 PDT 
<rdar://problem/44197960>