Bug 189350 – [GTK] fast/forms/color/input-appearance-color.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

fast/forms/color/input-appearance-color.html [ Failure ]

I think this is failing due to r235435, which changed the style of the color pickers, and we only need to update our expectations. But currently something happens to the buildbox and I can't run the tests there to get the new expectations, so I'll keep an eye on this and I'll update the expectation as soon as I can.

[Carlos Bentzen]

Created attachment 351377 [details]
Patch

[Carlos Bentzen]

Test expectation changes introduced by r235435 can be seen in:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r235690%20%288052%29/retries/fast/forms/color/input-appearance-color-diffs.html

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r235690%20%288052%29/fast/forms/color/input-appearance-color-pretty-diff.html

[WebKit Commit Bot]

Comment on attachment 351377 [details]
Patch

Rejecting attachment 351377 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 351377, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=351377&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189350&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 351377 from bug 189350.
Fetching: https://bugs.webkit.org/attachment.cgi?id=351377
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Updating OpenSource
From https://git.webkit.org/git/WebKit
   58512529f8b..6511ba8de37  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 236737 = 58512529f8b1844bf530c7b3b73a7a18cce10342
r236741 = 6511ba8de379499ea459b7f51575bddbafa36298
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/9426568

[Michael Catanzaro]

Comment on attachment 351377 [details]
Patch

Yeah, it does need a ChangeLog entry.

[Carlos Bentzen]

(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 351377 [details]
> Patch
> 
> Yeah, it does need a ChangeLog entry.

Indeed. Forgot a git-ammend there.

[Carlos Bentzen]

Created attachment 351393 [details]
Patch

[Carlos Bentzen]

(In reply to Carlos Eduardo Ramalho from comment #5)
> (In reply to Michael Catanzaro from comment #4)
> > Comment on attachment 351377 [details]
> > Patch
> > 
> > Yeah, it does need a ChangeLog entry.
> 
> Indeed. Forgot a git-ammend there.

Interesting that webkit-patch didn't catch it.

[WebKit Commit Bot]

Comment on attachment 351393 [details]
Patch

Clearing flags on attachment: 351393

Committed r236752: <https://trac.webkit.org/changeset/236752>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.