Bug 189311 - [LFC] LayoutContext::displayBoxForLayoutBox() should return a Display::Box&
Summary: [LFC] LayoutContext::displayBoxForLayoutBox() should return a Display::Box&
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-05 11:20 PDT by zalan
Modified: 2018-09-05 11:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (47.61 KB, patch)
2018-09-05 11:33 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-09-05 11:20:20 PDT 
instead of Display::Box*
There should always be a valid display box associated with a layout box for layout purposes (it does not necessarily mean that there's _always_ a display box for every layout box -for example in inline formatting context)
Comment 1 zalan 2018-09-05 11:33:17 PDT 
Created attachment 348950 [details]
Patch
Comment 2 zalan 2018-09-05 11:52:43 PDT 
Committed r235681: <https://trac.webkit.org/changeset/235681>
Comment 3 Radar WebKit Bug Importer 2018-09-05 11:53:27 PDT 
<rdar://problem/44147961>