Bug 189310 – Move ownership of outgoing source to RTCRtpSender backend

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Currently, they are owned by the peer connection backend, but it makes more sense to move to sender.
It should help simplifying replaceTrack implementation.

[youenn fablet]

Created attachment 348948 [details]
Patch

[youenn fablet]

Created attachment 348956 [details]
Patch

[EWS Watchlist]

Comment on attachment 348956 [details]
Patch

Attachment 348956 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9105982

New failing tests:
css3/filters/backdrop/add-remove-add-backdrop-filter.html

[EWS Watchlist]

Created attachment 348966 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Comment on attachment 348956 [details]
Patch

Error is unrelated

[WebKit Commit Bot]

Comment on attachment 348956 [details]
Patch

Rejecting attachment 348956 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 348956, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348956&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189310&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 348956 from bug 189310.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348956
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 5 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h
patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h
Hunk #2 FAILED at 55.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9109638

[youenn fablet]

Created attachment 349000 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 349000 [details]
Patch for landing

Clearing flags on attachment: 349000

Committed r235722: <https://trac.webkit.org/changeset/235722>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44168673>