https://bug1368555.bmoattachments.org/attachment.cgi?id=8923730 Scroll somewhere to the right. Safari TP release 64 (Safari 12.1, WebKit 13607.1.3.3) crashes. Safari stable 11.1.2 does not crash.
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00000001413b1913 WebCore::RenderThemeMac::paintSearchFieldCancelButton(WebCore::RenderBox const&, WebCore::PaintInfo const&, WebCore::IntRect const&) + 1363 1 com.apple.WebCore 0x000000014221c65c WebCore::RenderTheme::paint(WebCore::RenderBox const&, WebCore::ControlStates&, WebCore::PaintInfo const&, WebCore::LayoutRect const&) + 1564 2 com.apple.WebCore 0x0000000140df3fef WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 943 3 com.apple.WebCore 0x0000000140df143b WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 75 ...
<rdar://problem/44143049>
Created attachment 358204 [details] Test reduction
Created attachment 358278 [details] Patch
Comment on attachment 358278 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358278&action=review > Source/WebCore/rendering/RenderThemeMac.mm:2080 > + // Set horizontal position back to based on the content direction (cancelButtonRectForBounds() only knows about system direction). Nit - I think you missed a word in "…back to based on the…"
Created attachment 358280 [details] Patch
Comment on attachment 358280 [details] Patch Clearing flags on attachment: 358280 Committed r239604: <https://trac.webkit.org/changeset/239604>
All reviewed patches have been landed. Closing bug.