Bug 189298 – Update code style guidelines for using namespace inside a namespace definition

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Fujii Hironori]

Update code style guidelines for using namespace inside a namespace definition

https://webkit.org/code-style-guidelines/#using-position

> [](#using-position) In implementation files, put all other "using" statements at the beginning of the file, before any namespace definitions and after any "include" statements.
> 
> ###### Right:
> 
> ```cpp
> // HTMLSelectElement.cpp
> 
> using namespace other;
> 
> namespace WebCore {
> 
> } // namespace WebCore
> ```
> 
> ###### Wrong:
> 
> ```cpp
> // HTMLSelectElement.cpp
> 
> namespace WebCore {
> 
> using namespace other;
> 
> } // namespace WebCore
> ```


[webkit-dev] Moving WebCore to unified source builds and style changes.
https://lists.webkit.org/pipermail/webkit-dev/2017-October/029656.html

> 1) Move all “using namespace <name>;” inside the WebCore namespace (they used to be in the global namespace) and change to "using WebCore::<type-name>;” in .mm files.

[Fujii Hironori]

Created attachment 348897 [details]
Patch

[Fujii Hironori]

Comment on attachment 348897 [details]
Patch

Clearing flags on attachment: 348897

Committed r235717: <https://trac.webkit.org/changeset/235717>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44165719>