Bug 189297 - Remove unused bad_optional_access implementation.
Summary: Remove unused bad_optional_access implementation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-04 21:47 PDT by Mark Lam
Modified: 2018-09-05 00:53 PDT (History)
16 users (show)

See Also:

Attachments
proposed patch. (1.35 KB, patch)
2018-09-04 21:52 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-09-04 21:47:54 PDT 
This is a speculative fix for resolving build errors arising from conflicting definitions of bad_optional_access when building WebKit with the latest clang.
Comment 1 Mark Lam 2018-09-04 21:52:11 PDT 
Created attachment 348893 [details]
proposed patch.
Comment 2 Mark Lam 2018-09-04 21:52:45 PDT 
Comment on attachment 348893 [details]
proposed patch.

I'll wait for EWS confirmation before landing.
Comment 3 David Kilzer (:ddkilzer) 2018-09-04 21:56:29 PDT 
Comment on attachment 348893 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2018-09-05 00:26:17 PDT 
Comment on attachment 348893 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 WebKit Commit Bot 2018-09-05 00:52:24 PDT 
Comment on attachment 348893 [details]
proposed patch.

Clearing flags on attachment: 348893

Committed r235661: <https://trac.webkit.org/changeset/235661>
Comment 6 WebKit Commit Bot 2018-09-05 00:52:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-05 00:53:17 PDT 
<rdar://problem/44130109>