WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189297
Remove unused bad_optional_access implementation.
https://bugs.webkit.org/show_bug.cgi?id=189297
Summary
Remove unused bad_optional_access implementation.
Mark Lam
Reported
2018-09-04 21:47:54 PDT
This is a speculative fix for resolving build errors arising from conflicting definitions of bad_optional_access when building WebKit with the latest clang.
Attachments
proposed patch.
(1.35 KB, patch)
2018-09-04 21:52 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2018-09-04 21:52:11 PDT
Created
attachment 348893
[details]
proposed patch.
Mark Lam
Comment 2
2018-09-04 21:52:45 PDT
Comment on
attachment 348893
[details]
proposed patch. I'll wait for EWS confirmation before landing.
David Kilzer (:ddkilzer)
Comment 3
2018-09-04 21:56:29 PDT
Comment on
attachment 348893
[details]
proposed patch. r=me
Mark Lam
Comment 4
2018-09-05 00:26:17 PDT
Comment on
attachment 348893
[details]
proposed patch. Thanks for the review. Landing now.
WebKit Commit Bot
Comment 5
2018-09-05 00:52:24 PDT
Comment on
attachment 348893
[details]
proposed patch. Clearing flags on attachment: 348893 Committed
r235661
: <
https://trac.webkit.org/changeset/235661
>
WebKit Commit Bot
Comment 6
2018-09-05 00:52:26 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-09-05 00:53:17 PDT
<
rdar://problem/44130109
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug