Bug 189295 - [macOS] Cannot change font size at selection until font panel is shown
Summary: [macOS] Cannot change font size at selection until font panel is shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 189356
  Show dependency tree / graph
 
Reported: 2018-09-04 21:24 PDT by Wenson Hsieh
Modified: 2018-09-06 12:46 PDT (History)
8 users (show)

See Also:

Attachments
WIP (63.77 KB, patch)
2018-09-04 21:33 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
WIP 2 (73.39 KB, patch)
2018-09-05 11:19 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
First pass (79.17 KB, patch)
2018-09-05 17:00 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebase on trunk (78.34 KB, patch)
2018-09-05 17:24 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Try to fix the build (77.94 KB, patch)
2018-09-05 17:46 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix 32-bit macOS build (77.98 KB, patch)
2018-09-05 18:07 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.10 MB, application/zip)
2018-09-05 19:42 PDT, EWS Watchlist 		no flags Details
Patch for EWS (78.43 KB, patch)
2018-09-06 08:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (78.43 KB, patch)
2018-09-06 12:08 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-09-04 21:24:19 PDT 
<rdar://problem/35593389>
Comment 1 Wenson Hsieh 2018-09-04 21:33:57 PDT 
Created attachment 348892 [details]
WIP
Comment 2 Wenson Hsieh 2018-09-05 11:19:48 PDT 
Created attachment 348947 [details]
WIP 2
Comment 3 Wenson Hsieh 2018-09-05 17:00:35 PDT 
Created attachment 348981 [details]
First pass
Comment 4 Wenson Hsieh 2018-09-05 17:24:42 PDT 
Created attachment 348984 [details]
Rebase on trunk
Comment 5 Wenson Hsieh 2018-09-05 17:46:24 PDT 
Created attachment 348986 [details]
Try to fix the build
Comment 6 Wenson Hsieh 2018-09-05 18:07:05 PDT 
Created attachment 348989 [details]
Fix 32-bit macOS build
Comment 7 EWS Watchlist 2018-09-05 19:42:17 PDT 
Comment on attachment 348989 [details]
Fix 32-bit macOS build

Attachment 348989 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9108959

New failing tests:
css3/filters/backdrop/add-remove-add-backdrop-filter.html
Comment 8 EWS Watchlist 2018-09-05 19:42:19 PDT 
Created attachment 348995 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 Ryosuke Niwa 2018-09-05 22:04:58 PDT 
Comment on attachment 348989 [details]
Fix 32-bit macOS build

r=me. This patch probably didn't introduce a regression in backdrop filter LOL.
Comment 10 Wenson Hsieh 2018-09-06 07:29:45 PDT 
(In reply to Ryosuke Niwa from comment #9)
> Comment on attachment 348989 [details]
> Fix 32-bit macOS build
> 
> r=me. This patch probably didn't introduce a regression in backdrop filter
> LOL.

Yeah, this backdrop filter test passes locally for me (and I've also seen it flaky on other unrelated patches on EWS), but I'll do another EWS run to be on the safe side.
Comment 11 Wenson Hsieh 2018-09-06 08:45:36 PDT 
Created attachment 349029 [details]
Patch for EWS
Comment 12 Wenson Hsieh 2018-09-06 12:08:34 PDT 
Created attachment 349050 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2018-09-06 12:46:45 PDT 
Comment on attachment 349050 [details]
Patch for landing

Clearing flags on attachment: 349050

Committed r235748: <https://trac.webkit.org/changeset/235748>
Comment 14 WebKit Commit Bot 2018-09-06 12:46:47 PDT 
All reviewed patches have been landed.  Closing bug.