RESOLVED FIXED189287
Add generic entrypoint and run loop in TestWebKitAPI 
https://bugs.webkit.org/show_bug.cgi?id=189287
Summary Add generic entrypoint and run loop in TestWebKitAPI
Don Olmstead
Reported 2018-09-04 17:14:44 PDT
The JSCOnly implementation is really a generic implementation. Also main.cpp is the same as WPE's.
Attachments
Patch (5.98 KB, patch)
2018-09-04 17:57 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (5.99 KB, patch)
2018-09-04 18:00 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-09-04 17:57:05 PDT
Created attachment 348878 [details] Patch
EWS Watchlist
Comment 2 2018-09-04 17:58:50 PDT
Attachment 348878 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/generic/UtilitiesGeneric.cpp:38: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-09-04 18:00:57 PDT
Created attachment 348880 [details] Patch
Michael Catanzaro
Comment 4 2018-09-04 18:38:00 PDT
Comment on attachment 348880 [details] Patch Good
WebKit Commit Bot
Comment 5 2018-09-04 18:57:07 PDT
Comment on attachment 348880 [details] Patch Clearing flags on attachment: 348880 Committed r235654: <https://trac.webkit.org/changeset/235654>
WebKit Commit Bot
Comment 6 2018-09-04 18:57:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-04 18:58:19 PDT
<rdar://problem/44122651>
Note You need to log in before you can comment on or make changes to this bug.