Bug 189287 - Add generic entrypoint and run loop in TestWebKitAPI
Summary: Add generic entrypoint and run loop in TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-04 17:14 PDT by Don Olmstead
Modified: 2018-09-04 18:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.98 KB, patch)
2018-09-04 17:57 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (5.99 KB, patch)
2018-09-04 18:00 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-09-04 17:14:44 PDT 
The JSCOnly implementation is really a generic implementation. Also main.cpp is the same as WPE's.
Comment 1 Don Olmstead 2018-09-04 17:57:05 PDT 
Created attachment 348878 [details]
Patch
Comment 2 EWS Watchlist 2018-09-04 17:58:50 PDT 
Attachment 348878 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/generic/UtilitiesGeneric.cpp:38:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-09-04 18:00:57 PDT 
Created attachment 348880 [details]
Patch
Comment 4 Michael Catanzaro 2018-09-04 18:38:00 PDT 
Comment on attachment 348880 [details]
Patch

Good
Comment 5 WebKit Commit Bot 2018-09-04 18:57:07 PDT 
Comment on attachment 348880 [details]
Patch

Clearing flags on attachment: 348880

Committed r235654: <https://trac.webkit.org/changeset/235654>
Comment 6 WebKit Commit Bot 2018-09-04 18:57:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-04 18:58:19 PDT 
<rdar://problem/44122651>