Bug 189282 – [CMake] Make TestWebKitAPI dependencies explicit

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Don Olmstead]

The config.h file in TestWebKitAPI is for all the Test* builds. This means that TestWTF can technically depend on headers from JavaScriptCore, WebCore and WebKit.

[Don Olmstead]

Created attachment 348867 [details]
Patch

[EWS Watchlist]

Attachment 348867 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/CMakeLists.txt:19:  Alphabetical sorting problem. "JavaScriptCoreForwardingHeaders" should be before "WTFForwardingHeaders".  [list/order] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Don Olmstead]

Created attachment 348872 [details]
Patch

[Fujii Hironori]

I fixed this issue in Bug 184441. 
How can you reproduce?

[Don Olmstead]

(In reply to Fujii Hironori from comment #4)
> I fixed this issue in Bug 184441. 
> How can you reproduce?

Have an empty WebKitBuild.

build-webkit --generate-project-only

cd WebKitBuild/Release
ninja TestWTF

Or create a visual studio build and try and build TestWTF first.

[Fujii Hironori]

Comment on attachment 348872 [details]
Patch

You are right. I fixed a problem only for GTK and WPE. This patch looks good to me.

[Don Olmstead]

(In reply to Fujii Hironori from comment #6)
> Comment on attachment 348872 [details]
> Patch
> 
> You are right. I fixed a problem only for GTK and WPE. This patch looks good
> to me.

Thanks! This should make it so TestWTF never fails to compile due to missing headers.

[WebKit Commit Bot]

Comment on attachment 348872 [details]
Patch

Clearing flags on attachment: 348872

Committed r235653: <https://trac.webkit.org/changeset/235653>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.