RESOLVED FIXED 189281
Move replaceTrack logic to LibWebRTCPeerConnectionBackend 
https://bugs.webkit.org/show_bug.cgi?id=189281
Summary Move replaceTrack logic to LibWebRTCPeerConnectionBackend
youenn fablet
Reported 2018-09-04 16:23:04 PDT
Right now it is split between RTCPeerConnection and LibWebRTCPeerConnectionBackend. This makes it difficult to reason about.
Attachments
Patch (9.83 KB, patch)
2018-09-04 16:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (9.83 KB, patch)
2018-09-05 08:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.61 KB, patch)
2018-09-05 10:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-09-04 16:26:20 PDT
Created attachment 348866 [details] Patch
youenn fablet
Comment 2 2018-09-05 08:49:03 PDT
Created attachment 348926 [details] Patch
Eric Carlson
Comment 3 2018-09-05 09:58:59 PDT
Comment on attachment 348926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348926&action=review > Source/WebCore/ChangeLog:9 > + This allows maing the logic easier to understand. Nit: "This allows maing the logic" -> "This makes the logic" > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:412 > +static inline bool tryUpdatingTrackSource(MediaStreamTrack& currentTrack, MediaStreamTrack* newTrack, const Vector<Source>& sources) It doesn't look like newTrack can be NULL, can you make it a MediaStreamTrack& ?
youenn fablet
Comment 4 2018-09-05 10:39:13 PDT
Created attachment 348938 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-09-05 11:55:01 PDT
Comment on attachment 348938 [details] Patch for landing Clearing flags on attachment: 348938 Committed r235682: <https://trac.webkit.org/changeset/235682>
WebKit Commit Bot
Comment 6 2018-09-05 11:55:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-05 11:56:21 PDT
<rdar://problem/44148039>
Note You need to log in before you can comment on or make changes to this bug.