Bug 189273 - Add WinCairo to bot watcher's dashboard.
Summary: Add WinCairo to bot watcher's dashboard.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-04 13:56 PDT by Ross Kirsling
Modified: 2018-09-05 10:59 PDT (History)
8 users (show)

See Also:

Attachments
Patch (36.20 KB, patch)
2018-09-04 14:00 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Screenshot (989.83 KB, image/png)
2018-09-05 09:48 PDT, Ross Kirsling 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-09-04 13:56:45 PDT 
Add WinCairo to bot watcher's dashboard.
Comment 1 Ross Kirsling 2018-09-04 14:00:01 PDT 
Created attachment 348846 [details]
Patch
Comment 2 Daniel Bates 2018-09-04 20:45:25 PDT 
Comment on attachment 348846 [details]
Patch

What license does the Windows logo have? Is it compatible with our BSD license?
Comment 3 Ross Kirsling 2018-09-05 08:49:59 PDT 
(In reply to Daniel Bates from comment #2)
> Comment on attachment 348846 [details]
> Patch
> 
> What license does the Windows logo have? Is it compatible with our BSD
> license?

I grabbed it from Wikimedia Commons, where it's claimed to be public domain (as it is too simplistic to be copyrighted). We actually already have a Windows8.png in that directory that could be used for 10 instead, but technically it seems they updated the blue hue, so I thought I'd make a new one as with the various Mac releases. FWIW, seems like the only attribution listed in that folder is for the Linux penguin that WPE is using.
Comment 4 Lucas Forschler 2018-09-05 09:02:56 PDT 
This looks ok to me... Aakash, do we have a UAT environment for the dashboard by chance?
Comment 5 Aakash Jain 2018-09-05 09:25:24 PDT 
(In reply to Lucas Forschler from comment #4)
> This looks ok to me... Aakash, do we have a UAT environment for the dashboard by chance?
We do have UAT. However, dashboard changes can easily be tested locally as well.
Comment 6 Ross Kirsling 2018-09-05 09:48:15 PDT 
Created attachment 348932 [details]
Screenshot

Seems to look as intended when serving the dashboard directory locally.
Comment 7 WebKit Commit Bot 2018-09-05 10:58:52 PDT 
Comment on attachment 348846 [details]
Patch

Clearing flags on attachment: 348846

Committed r235678: <https://trac.webkit.org/changeset/235678>
Comment 8 WebKit Commit Bot 2018-09-05 10:58:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-09-05 10:59:29 PDT 
<rdar://problem/44145189>