Bug 18927 - Unify path data debug output
Summary: Unify path data debug output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-07 12:02 PDT by Rob Buis
Modified: 2008-05-25 03:44 PDT (History)
0 users

See Also:


Attachments
Unified code and text dumps for Mac Tiger (974.29 KB, patch)
2008-05-07 12:20 PDT, Rob Buis
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2008-05-07 12:02:34 PDT
It turns out that dump to text for path data is different on the various platforms, as noted by Ariya. Together we settled on a mixed version between
how mac and how Qt outputs the path data, namely using a space after each path command:

old mac (M100.00,100.00L200.00,100.00)

new proposed (M100.00,100.00 L200.00,100.00)

This allow a bit more readable output, but does not add too much extra space(s).
Comment 1 Rob Buis 2008-05-07 12:20:59 PDT
Created attachment 21005 [details]
Unified code and text dumps for Mac Tiger

I hope I got the CFString stuff right. Unfortunately the patch is big...
Cheers,

Rob.
Comment 2 Eric Seidel (no email) 2008-05-20 14:06:38 PDT
Comment on attachment 21005 [details]
Unified code and text dumps for Mac Tiger

I'm OK with this.  You'll of course need to re-baseline again.
Comment 3 Rob Buis 2008-05-25 03:44:18 PDT
Fixed by r34117.