Bug 189243 - [WPE][GTK] Add more unused result warnings to JSC API
Summary: [WPE][GTK] Add more unused result warnings to JSC API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-03 06:02 PDT by Michael Catanzaro
Modified: 2018-09-04 07:49 PDT (History)
9 users (show)

See Also:


Attachments
[WPE][GTK] Add more unused result warnings to JSC API (2.65 KB, patch)
2018-09-03 06:04 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-09-03 06:02:12 PDT
Add more unused result warnings to JSC API, as suggested by Carlos Garcia
Comment 1 Michael Catanzaro 2018-09-03 06:04:42 PDT
Created attachment 348767 [details]
[WPE][GTK] Add more unused result warnings to JSC API
Comment 2 Carlos Garcia Campos 2018-09-03 06:12:37 PDT
Comment on attachment 348767 [details]
[WPE][GTK] Add more unused result warnings to JSC API

What about jsc_value_constructor_call and jsc_value_constructor_callv? Is it more obvious that you should get a value in those cases?
Comment 3 Michael Catanzaro 2018-09-03 06:48:47 PDT
Nope, I just grepped for "evaluate" because you suggested that one, I didn't consider jsc_value_constructor_call(). Will add it there too
Comment 4 Michael Catanzaro 2018-09-03 06:51:36 PDT
Wait, no, it is indeed more obvious that you should get a value from those, because they're constructors. Why would you call a constructor and not expect to get a value. :P So yes, it's not needed there IMO.
Comment 5 WebKit Commit Bot 2018-09-04 07:49:03 PDT
Comment on attachment 348767 [details]
[WPE][GTK] Add more unused result warnings to JSC API

Clearing flags on attachment: 348767

Committed r235612: <https://trac.webkit.org/changeset/235612>
Comment 6 WebKit Commit Bot 2018-09-04 07:49:05 PDT
All reviewed patches have been landed.  Closing bug.