Add more unused result warnings to JSC API, as suggested by Carlos Garcia
Created attachment 348767 [details] [WPE][GTK] Add more unused result warnings to JSC API
Comment on attachment 348767 [details] [WPE][GTK] Add more unused result warnings to JSC API What about jsc_value_constructor_call and jsc_value_constructor_callv? Is it more obvious that you should get a value in those cases?
Nope, I just grepped for "evaluate" because you suggested that one, I didn't consider jsc_value_constructor_call(). Will add it there too
Wait, no, it is indeed more obvious that you should get a value from those, because they're constructors. Why would you call a constructor and not expect to get a value. :P So yes, it's not needed there IMO.
Comment on attachment 348767 [details] [WPE][GTK] Add more unused result warnings to JSC API Clearing flags on attachment: 348767 Committed r235612: <https://trac.webkit.org/changeset/235612>
All reviewed patches have been landed. Closing bug.